From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6586 invoked by alias); 12 Apr 2004 12:15:11 -0000 Mailing-List: contact mauve-discuss-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: mauve-discuss-owner@sources.redhat.com Received: (qmail 6574 invoked from network); 12 Apr 2004 12:15:09 -0000 Received: from unknown (HELO nescio.wildebeest.org) (82.161.94.186) by sources.redhat.com with SMTP; 12 Apr 2004 12:15:09 -0000 Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark) by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian)) id 1BD0L5-0003pN-00; Mon, 12 Apr 2004 14:14:59 +0200 Subject: Re: mauve ./ChangeLog gnu/testlet/java/lang/Charac ... From: Mark Wielaard To: crawley@sources.redhat.com Cc: mauve-discuss@sources.redhat.com In-Reply-To: <20040408160537.21917.qmail@sources.redhat.com> References: <20040408160537.21917.qmail@sources.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-cu9eg4MtX01n+Cb2O+4u" Message-Id: <1081772102.13170.567.camel@elsschot.wildebeest.org> Mime-Version: 1.0 Date: Mon, 12 Apr 2004 12:15:00 -0000 X-SW-Source: 2004-q2/txt/msg00023.txt.bz2 --=-cu9eg4MtX01n+Cb2O+4u Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Content-length: 926 Hi Stephen, On Thu, 2004-04-08 at 18:05, crawley@sources.redhat.com wrote: > Fixed java.lang.Character.unicode test to match JDK 1.4 semantics Nice cleanup! One thing that seems to be missing though is the CharInfo.decimalDigit field. Without such a field the code will not compile. But it seems we don't use that field during the tests either. Should I add the following or did you have something else in mind? diff -u -r1.3 CharInfo.java --- gnu/testlet/java/lang/Character/CharInfo.java 4 Feb 1999 18:46:19= -0000 1.3 +++ gnu/testlet/java/lang/Character/CharInfo.java 12 Apr 2004 12:12:4= 4 -0000 @@ -29,6 +29,7 @@ { public String name; public String category; + public int decimalDigit; public int digit; public int numericValue; public char uppercase; With that it compiles again and java.lang.Character.unicode gives 0 of 3578944 tests failed for GNU Classpath :) Cheers, Mark --=-cu9eg4MtX01n+Cb2O+4u Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part Content-length: 189 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (GNU/Linux) iD8DBQBAeohExVhZCJWr9QwRAtPqAJ47jy3adFLbLhPsgasfks7fjUEABwCggWA5 dh/YAGPPdDKgBedQxpnUDWY= =N3y8 -----END PGP SIGNATURE----- --=-cu9eg4MtX01n+Cb2O+4u--