From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4737 invoked by alias); 15 Apr 2004 21:04:01 -0000 Mailing-List: contact mauve-discuss-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: mauve-discuss-owner@sources.redhat.com Received: (qmail 4725 invoked from network); 15 Apr 2004 21:03:59 -0000 Received: from unknown (HELO nescio.wildebeest.org) (82.161.94.186) by sources.redhat.com with SMTP; 15 Apr 2004 21:03:59 -0000 Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark) by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian)) id 1BEE1Y-0005nZ-00; Thu, 15 Apr 2004 23:03:52 +0200 Subject: Re: Mauve patch From: Mark Wielaard To: Archie Cobbs Cc: commit-classpath@gnu.org, mauve-discuss@sources.redhat.com In-Reply-To: <200404061346.i36DkRdh019920@arch20m.dellroad.org> References: <200404061346.i36DkRdh019920@arch20m.dellroad.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-klJW0xPzmg9EhotYadQP" Message-Id: <1082063032.1986.7.camel@elsschot.wildebeest.org> Mime-Version: 1.0 Date: Thu, 15 Apr 2004 21:04:00 -0000 X-SW-Source: 2004-q2/txt/msg00034.txt.bz2 --=-klJW0xPzmg9EhotYadQP Content-Type: multipart/mixed; boundary="=-rDHGVCNHLr2352Tkvwh4" --=-rDHGVCNHLr2352Tkvwh4 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Content-length: 1130 Hi, On Tue, 2004-04-06 at 15:46, Archie Cobbs wrote: > This patch doesn't guarantee anything, and in general it's impossible > to make this test "correct" because the spec allows finalization and > reference enqueuing to happen after arbitrarily long delays. >=20 > For example, a JVM that *never* finalizes is still within the spec > (it would probably throw OutOfMemoryError's more readily though). >=20 > This patch simply makes the test "correct" for JC (and possibly > some other VM(s) out there). Since there's no way to *ensure* the > finalizer and reference enqueing thread(s) have run, we just try > to give them every opportunity to do so before declaring that their > work should be done. I committed it to mauve as follows since it doesn't break things for others and might actually help. 2004-04-15 Archie Cobbs * gnu/testlet/java/lang/ref/PhantomReference/phantom.java: Give the runtime some more hints (Thread.yield/System.gc) that it should really garbage collect. But a "non-portable" section in Mauve is also a good idea. It is just more work :) Cheers, Mark --=-rDHGVCNHLr2352Tkvwh4 Content-Disposition: inline; filename=phantom.patch Content-Type: text/x-patch; name=phantom.patch; charset=iso-8859-1 Content-Transfer-Encoding: base64 Content-length: 989 SW5kZXg6IGdudS90ZXN0bGV0L2phdmEvbGFuZy9yZWYvUGhhbnRvbVJlZmVy ZW5jZS9waGFudG9tLmphdmENCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NClJD UyBmaWxlOiAvY3ZzL21hdXZlL21hdXZlL2dudS90ZXN0bGV0L2phdmEvbGFu Zy9yZWYvUGhhbnRvbVJlZmVyZW5jZS9waGFudG9tLmphdmEsdg0KcmV0cmll dmluZyByZXZpc2lvbiAxLjENCmRpZmYgLXUgLXIxLjEgcGhhbnRvbS5qYXZh DQotLS0gZ251L3Rlc3RsZXQvamF2YS9sYW5nL3JlZi9QaGFudG9tUmVmZXJl bmNlL3BoYW50b20uamF2YQkyNyBTZXAgMjAwMSAxNTo0NDowOSAtMDAwMAkx LjENCisrKyBnbnUvdGVzdGxldC9qYXZhL2xhbmcvcmVmL1BoYW50b21SZWZl cmVuY2UvcGhhbnRvbS5qYXZhCTE1IEFwciAyMDA0IDIwOjE4OjM0IC0wMDAw DQpAQCAtNTQsNiArNTQsOSBAQA0KICAgICBwaGFudG9tIHR3dCA9IG5ldyBw aGFudG9tICgpOw0KICAgICBQaGFudG9tUmVmZXJlbmNlIHdyID0gZ2VuUmVm IChxLCB0d3QpOw0KIA0KKyAgICAvLyBHaXZlIHRoZSBydW50aW1lIHNvbWUg aGludHMgdGhhdCBpdCBzaG91bGQgcmVhbGx5IGdhcmJhZ2UgY29sbGVjdC4N CisgICAgU3lzdGVtLmdjICgpOw0KKyAgICBTeXN0ZW0ueWllbGQgKCk7DQog ICAgIFN5c3RlbS5nYyAoKTsNCiANCiAgICAgUmVmZXJlbmNlIHIgPSBxLnBv bGwgKCk7DQo= --=-rDHGVCNHLr2352Tkvwh4-- --=-klJW0xPzmg9EhotYadQP Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part Content-length: 189 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (GNU/Linux) iD8DBQBAfvi3xVhZCJWr9QwRAoPvAJ9fgGDhNEbsMs/+DTZulgS/6yu0lgCeIevi PVKeC9SJdLYdUQMMUTzSo3s= =WyyJ -----END PGP SIGNATURE----- --=-klJW0xPzmg9EhotYadQP--