From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23207 invoked by alias); 7 Oct 2004 21:55:55 -0000 Mailing-List: contact mauve-discuss-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: mauve-discuss-owner@sources.redhat.com Received: (qmail 23194 invoked from network); 7 Oct 2004 21:55:54 -0000 Received: from unknown (HELO johanna.resare.com) (193.14.119.138) by sourceware.org with SMTP; 7 Oct 2004 21:55:54 -0000 Received: from molly.resare.com (c-2f1f72d5.01-60-6c6b701.cust.bredbandsbolaget.se [213.114.31.47]) by johanna.resare.com (Postfix) with ESMTP id 500ECD6D09 for ; Thu, 7 Oct 2004 23:55:51 +0200 (CEST) Received: from [192.168.110.42] (marit [192.168.110.42]) by molly.resare.com (Postfix) with ESMTP id D2F7DD2E1D for ; Thu, 7 Oct 2004 23:55:53 +0200 (CEST) Subject: bogus test in gnu.testlet.java.net.DatagramPacket.DatagramPacketTest2 From: Noa Resare To: mauve-discuss@sources.redhat.com Content-Type: multipart/mixed; boundary="=-opGht4dQ2TpxvB2Dwmic" Date: Thu, 07 Oct 2004 21:55:00 -0000 Message-Id: <1097186153.1324.15.camel@localhost.localdomain> Mime-Version: 1.0 X-SW-Source: 2004-q4/txt/msg00000.txt.bz2 --=-opGht4dQ2TpxvB2Dwmic Content-Type: text/plain Content-Transfer-Encoding: 7bit Content-length: 460 In invalid_addr() in gnu.testlet.java.net.DatagramPacket.DatagramPacketTest2.java the code tests if DatagramPacket throws NullPointerException on null InetAddress and null setAddress() argument. This is however not specified in either 1.5, 1.4.2 or 1.3.1 API javadoc and nor implemented in either sun's 1.4.2_05 nor classpath. Please apply the attached patch that removes the tests in question. cheers/noa ps. have anyone looked at the xml output patches? --=-opGht4dQ2TpxvB2Dwmic Content-Disposition: attachment; filename=mauve-DatagramPacket.patch Content-Type: text/x-patch; name=mauve-DatagramPacket.patch; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-length: 2018 Index: ChangeLog =================================================================== RCS file: /cvs/mauve/mauve/ChangeLog,v retrieving revision 1.676 diff -u -r1.676 ChangeLog --- ChangeLog 29 Sep 2004 20:00:51 -0000 1.676 +++ ChangeLog 7 Oct 2004 21:55:04 -0000 @@ -1,3 +1,8 @@ +2004-10-07 Noa Resare + + * gnu/testlet/java/net/DatagramPacket/DatagramPacketTest2.java + (invalid_addr): removed tests for invalid address. + 2004-09-29 Tom Tromey * gnu/testlet/java/util/Properties/AcuniaPropertiesTest.java Index: gnu/testlet/java/net/DatagramPacket/DatagramPacketTest2.java =================================================================== RCS file: /cvs/mauve/mauve/gnu/testlet/java/net/DatagramPacket/DatagramPacketTest2.java,v retrieving revision 1.2 diff -u -r1.2 DatagramPacketTest2.java --- gnu/testlet/java/net/DatagramPacket/DatagramPacketTest2.java 3 Jun 2004 14:31:09 -0000 1.2 +++ gnu/testlet/java/net/DatagramPacket/DatagramPacketTest2.java 7 Oct 2004 21:55:04 -0000 @@ -212,42 +212,6 @@ } } - // check for invalid IP address - public void invalid_addr() - { - try - { - DatagramPacket request = new DatagramPacket(buf, 10, null, PORT); - errormsg("invalid_addr", 1, true, "NullPointerException"); - } - catch (NullPointerException e) - { - harness.check(true); - } - - try - { - DatagramPacket request = new DatagramPacket(buf, 10, ia, PORT); - request.setAddress(null); - errormsg("invalid_addr", 2, true, "NullPointerException"); - } - catch (NullPointerException e) - { - harness.check(true); - } - - try - { - DatagramPacket reply = new DatagramPacket(buf, 10); - reply.setAddress(null); - errormsg("invalid_addr", 3, true, "NullPointerException"); - } - catch (NullPointerException e) - { - harness.check(true); - } - } - // check for invalid port number public void invalid_port() { @@ -331,7 +295,6 @@ m.invalid_buf(); m.invalid_buflen(); - m.invalid_addr(); m.invalid_port(); } } --=-opGht4dQ2TpxvB2Dwmic--