From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17097 invoked by alias); 22 Sep 2005 17:18:08 -0000 Mailing-List: contact mauve-discuss-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: mauve-discuss-owner@sources.redhat.com Received: (qmail 16950 invoked by uid 22791); 22 Sep 2005 17:17:28 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Thu, 22 Sep 2005 17:17:28 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j8MHHQwv016065 for ; Thu, 22 Sep 2005 13:17:26 -0400 Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com [172.16.14.4]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j8MHHQV24812; Thu, 22 Sep 2005 13:17:26 -0400 Received: from tow.toronto.redhat.com (tow.toronto.redhat.com [172.16.14.160]) by pobox.toronto.redhat.com (8.12.8/8.12.8) with ESMTP id j8MHHQoF029119; Thu, 22 Sep 2005 13:17:26 -0400 Subject: Re: [cp-patches]: L&F fix From: Lillian Angel To: Roman Kennke Cc: mauve-discuss@sources.redhat.com In-Reply-To: <1127407082.6513.19.camel@localhost.localdomain> References: <1127403142.25403.29.camel@tow.toronto.redhat.com> <1127407082.6513.19.camel@localhost.localdomain> Content-Type: multipart/mixed; boundary="=-IWdPVsFmy+YR+jsd0YyS" Date: Thu, 22 Sep 2005 17:18:00 -0000 Message-Id: <1127409446.3001.2.camel@tow.toronto.redhat.com> Mime-Version: 1.0 X-SW-Source: 2005-q3/txt/msg00061.txt.bz2 --=-IWdPVsFmy+YR+jsd0YyS Content-Type: text/plain Content-Transfer-Encoding: 7bit Content-length: 778 On Thu, 2005-09-22 at 18:38 +0200, Roman Kennke wrote: > Hi Lillian, > > you have committed the following: > > - "Tree.textBackground", new ColorUIResource(new Color(255, 255, > 255)), > - "Tree.textForeground", new ColorUIResource(Color.black), > + "Tree.textBackground", new ColorUIResource(new Color(192, 192, > 192)), > + "Tree.textForeground", new ColorUIResource(new Color(0, 0, 0)), > > IMO writing new ColorUIResource(Color.BLACK) is slightly more efficient > than new ColorUIResource(new Color(0, 0, 0)). > > Also, have you seen that there is a testcase for > BasicLookAndFeel.initComponentDefaults(). If these values are not > already in this testcase, please add them. No problem. Attached is the patch. I do not have commit access. Lillian --=-IWdPVsFmy+YR+jsd0YyS Content-Disposition: attachment; filename=mauve.diff Content-Type: text/x-patch; name=mauve.diff; charset=us-ascii Content-Transfer-Encoding: 7bit Content-length: 2278 Index: gnu/testlet/javax/swing/plaf/basic/BasicLookAndFeel/initComponentDefaults.java =================================================================== RCS file: /cvs/mauve/mauve/gnu/testlet/javax/swing/plaf/basic/BasicLookAndFeel/initComponentDefaults.java,v retrieving revision 1.3 diff -u -r1.3 initComponentDefaults.java --- gnu/testlet/javax/swing/plaf/basic/BasicLookAndFeel/initComponentDefaults.java 2 Sep 2005 08:49:36 -0000 1.3 +++ gnu/testlet/javax/swing/plaf/basic/BasicLookAndFeel/initComponentDefaults.java 22 Sep 2005 17:14:36 -0000 @@ -449,7 +449,9 @@ harness.check(defaults.get("Tree.rowHeight"), new Integer(16)); harness.check(defaults.get("Tree.scrollsOnExpand"), Boolean.TRUE); harness.check(defaults.get("Tree.selectionBorderColor"), new ColorUIResource(0, 0, 0)); - + harness.check(defaults.get("Tree.textForeground"), new ColorUIResource(Color.black)); + harness.check(defaults.get("Tree.textBackground"), new ColorUIResource(new Color(192, 192,192)); + harness.checkPoint("Viewport"); harness.check(defaults.get("Viewport.font"), new FontUIResource("Dialog", Font.PLAIN, 12)); } Index: gnu/testlet/javax/swing/plaf/metal/MetalLookAndFeel/getDefaults.java =================================================================== RCS file: /cvs/mauve/mauve/gnu/testlet/javax/swing/plaf/metal/MetalLookAndFeel/getDefaults.java,v retrieving revision 1.1 diff -u -r1.1 getDefaults.java --- gnu/testlet/javax/swing/plaf/metal/MetalLookAndFeel/getDefaults.java 9 Sep 2005 13:13:37 -0000 1.1 +++ gnu/testlet/javax/swing/plaf/metal/MetalLookAndFeel/getDefaults.java 22 Sep 2005 17:14:36 -0000 @@ -877,7 +877,7 @@ harness.check(defaults.get("Tree.line"), new ColorUIResource(0, 0, 20)); harness.check(defaults.get("Tree.openIcon") instanceof MetalIconFactory.TreeFolderIcon); harness.check(defaults.getInt("Tree.rightChildIndent"), 13); - harness.check(defaults.getInt("Tree.rowHeight"), 0); + harness.check(defaults.getInt("Tree.rowHeight"), 16); harness.check(defaults.get("Tree.scrollsOnExpand"), Boolean.TRUE); harness.check(defaults.get("Tree.selectionBackground"), new ColorUIResource(0, 0, 28)); harness.check(defaults.get("Tree.selectionBorderColor"), new ColorUIResource(0, 0, 12)); --=-IWdPVsFmy+YR+jsd0YyS--