From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26899 invoked by alias); 15 Jan 2006 22:08:04 -0000 Received: (qmail 26891 invoked by uid 22791); 15 Jan 2006 22:08:03 -0000 X-Spam-Check-By: sourceware.org Received: from smtpq3.groni1.gr.home.nl (HELO smtpq3.groni1.gr.home.nl) (213.51.130.202) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 15 Jan 2006 22:08:01 +0000 Received: from [213.51.130.188] (port=37571 helo=smtp3.groni1.gr.home.nl) by smtpq3.groni1.gr.home.nl with esmtp (Exim 4.30) id 1EyG2V-0004Yb-6m; Sun, 15 Jan 2006 23:07:55 +0100 Received: from cc977442-a.ensch1.ov.home.nl ([82.75.254.165]:50832 helo=gnu.wildebeest.org) by smtp3.groni1.gr.home.nl with esmtp (Exim 4.30) id 1EyG2W-0001jv-Kk; Sun, 15 Jan 2006 23:07:56 +0100 Received: from elsschot.wildebeest.org ([192.168.1.26]) by gnu.wildebeest.org with esmtp (Exim 3.36 #1 (Debian)) id 1EyFhI-0004SH-00; Sun, 15 Jan 2006 22:46:00 +0100 Subject: Re: Updating Mauve tags From: Mark Wielaard To: Roman Kennke Cc: mauve-discuss@sources.redhat.com, classpath@gnu.org In-Reply-To: <1137274393.7808.6.camel@localhost.localdomain> References: <1137274393.7808.6.camel@localhost.localdomain> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-+wDAqzIZ1hdxARmEcdp8" Date: Sun, 15 Jan 2006 22:08:00 -0000 Message-Id: <1137361555.9102.78.camel@localhost.localdomain> Mime-Version: 1.0 X-AtHome-MailScanner-Information: Please contact support@home.nl for more information X-AtHome-MailScanner: Found to be clean X-IsSubscribed: yes Mailing-List: contact mauve-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: mauve-discuss-owner@sourceware.org X-SW-Source: 2006-q1/txt/msg00007.txt.bz2 --=-+wDAqzIZ1hdxARmEcdp8 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Content-length: 3170 Hi Roman, On Sat, 2006-01-14 at 22:33 +0100, Roman Kennke wrote: > (BTW: This is a Mauve topic, I CC the classpath list because the > mauve-discuss list seems so dead). Once upon a time there were lots of standard class library projects (kaffe, gcj, classpath) and we started cooperating by sharing a test suite. When most of these libraries merged together the test suite became a bit more the "gnu classpath" testsuite, but there are still independent users out there (although most of them are indeed pretty quiet - acunia used it for wonka, hp used it for chai, ibm used it for j9 and of course aicas uses it for jamaica, there are probably some others out there that never publicly announced their usage of the test suite.). > I see that we have a concept of tags in Mauve. That is a collection of > keys at the top of each test class. This way we can filter the tests. > ATM we have tags for the JDK versions like JDK1.4 JDK1.3 and so on and a > couple of other tags. However, it seems that they are not maintained in > a usable way, so most people simply include every tag that they can > think of (that is what's done in batch_run for example) to run all > tests. Why do you feel they aren't maintained in a usable way? A test should mention the minimum version that it should work against. And can mention newer versions for which the tests isn't valid anymore (although I don't know of many examples of that). The README explains as follows: Tags must all appear on a single line beginning "// Tags: ". =20=20=20=20=20=20=20=20 Many files test functionality that has existed since JDK1.0. The corresponding line in the source: =20=20=20=20=20=20=20=20 // Tags: JDK1.0 =20=20=20=20=20=20=20=20 Here is how you would tag something that first appeared in JDK1.2: =20=20=20=20=20=20=20=20 // Tags: JDK1.2 =20=20=20=20=20=20=20=20 Here is how you would tag something that was eliminated in JDK1.2: =20=20=20=20=20=20=20=20 // Tags: JDK1.0 !JDK1.2 =20=20=20=20=20=20=20=20 The idea behind this scheme is that it is undesirable to update all the files whenever we add a tag. So instead most tags are defined in terms of primitive tags, and then we note the exceptions. The reason the batch_run script lists all the tags is simply because it wants to run all the tests. > I would like to fix the tagging of the tests with regard to the JDK > versions. And since the current reference is JDK1.5, I would naturally > start with this one. What I propose to do is run all the tests under > JDK1.5 and set the JDK1.5 tag for all tests that pass there. For all > tests that FAIL and have the JDK1.5 tag set, this tag would have to be > removed. Later I would like to do the same for JDK1.4 and JDK1.3. (I > have no JDK1.2 JDK1.1 or JDK1.0 available, otherwise I would probably do > the same for these). It might be interesting to know what tests fail against which version of the reference implementation, but the reference implementation does have bugs, some of which aren't present in other implementations. Cheers, Mark --=-+wDAqzIZ1hdxARmEcdp8 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part Content-length: 189 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (GNU/Linux) iD8DBQBDysKTxVhZCJWr9QwRAsHNAKCeSDebKlV+Qmgox7iKmmz+Cwh1twCgnt4S sZJSOYktjOGlTNoGE3ojTX0= =yiCC -----END PGP SIGNATURE----- --=-+wDAqzIZ1hdxARmEcdp8--