From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11642 invoked by alias); 15 Jan 2006 23:59:51 -0000 Received: (qmail 11634 invoked by uid 22791); 15 Jan 2006 23:59:49 -0000 X-Spam-Check-By: sourceware.org Received: from kennke.org (HELO box7954.elkhouse.de) (213.9.79.54) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 15 Jan 2006 23:59:47 +0000 Received: from i64cf.i.strato-dslnet.de ([85.73.100.207] helo=[192.168.1.11]) by box7954.elkhouse.de with esmtpsa (TLS-1.0:RSA_ARCFOUR_MD5:16) (Exim 4.50) id 1EyInh-0008Iq-Ad; Mon, 16 Jan 2006 02:04:49 +0100 Subject: Re: Updating Mauve tags From: Roman Kennke To: Mark Wielaard Cc: mauve-discuss@sources.redhat.com, classpath@gnu.org In-Reply-To: <1137361555.9102.78.camel@localhost.localdomain> References: <1137274393.7808.6.camel@localhost.localdomain> <1137361555.9102.78.camel@localhost.localdomain> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-pu2QK4EF+Fq1aujKscqg" Date: Sun, 15 Jan 2006 23:59:00 -0000 Message-Id: <1137369579.7846.32.camel@localhost.localdomain> Mime-Version: 1.0 Mailing-List: contact mauve-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: mauve-discuss-owner@sourceware.org X-SW-Source: 2006-q1/txt/msg00008.txt.bz2 --=-pu2QK4EF+Fq1aujKscqg Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Content-length: 1456 Hi Mark, > > I see that we have a concept of tags in Mauve. That is a collection of > > keys at the top of each test class. This way we can filter the tests. > > ATM we have tags for the JDK versions like JDK1.4 JDK1.3 and so on and a > > couple of other tags. However, it seems that they are not maintained in > > a usable way, so most people simply include every tag that they can > > think of (that is what's done in batch_run for example) to run all > > tests. >=20 > Why do you feel they aren't maintained in a usable way? This was caused by a misunderstanding of the usage/meaning of those tags. I was thinking that when a test has the tag JDK1.x, that this test is meant to PASS under a JDK1.x-ish JDK. As Michael and others have pointed out on IRC this is not the case. If I want to test a JDK1.3-sh (for example) environment I should include JDK1.0 JDK1.1 JDK1.2 and JDK1.3 tags in my keys. The problem that I am seeing is when a test that is written to PASS under 1.4 fails under 1.5. There are lots of those tests in the testsuite for the javax.swing package. So my plan would have been to tag all tests that pass under JDK1.5 with the 1.5 tag and those that don't only with JDK1.4 or whatever is ok. Since the tags are not meant to be used that way, maybe we can do it different. Could we extend the choose-classes script to detect !JDK1.x tags in the tag header of java source files and don't include the test in a JDK1.x test run? /Roman --=-pu2QK4EF+Fq1aujKscqg Content-Type: application/pgp-signature; name=signature.asc Content-Description: Dies ist ein digital signierter Nachrichtenteil Content-length: 189 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (GNU/Linux) iD8DBQBDyuHrn1u2YFrInbcRAotyAJwJExdhMqAwZG/1dXEF3PSI8mRhEgCeK1tP s61VYRfNTfX8op9LXNDQI44= =wZWa -----END PGP SIGNATURE----- --=-pu2QK4EF+Fq1aujKscqg--