From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30954 invoked by alias); 14 Sep 2011 09:11:37 -0000 Received: (qmail 30945 invoked by uid 22791); 14 Sep 2011 09:11:36 -0000 X-SWARE-Spam-Status: No, hits=-1.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (80.101.103.228) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 14 Sep 2011 09:11:14 +0000 Subject: Re: RFC: fix for Mauve test javax/swing/Border/TitledBorder/constructors.java From: Mark Wielaard To: Pavel Tisnovsky Cc: mauve-discuss@sourceware.org In-Reply-To: <4E706C61.2030408@redhat.com> References: <4E60F752.1070308@redhat.com> <20110907023849.GI19081@rivendell.middle-earth.co.uk> <4E6769A0.8020906@redhat.com> <4E706C61.2030408@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Date: Wed, 14 Sep 2011 09:11:00 -0000 Message-ID: <1315991470.3691.15.camel@springer.wildebeest.org> Mime-Version: 1.0 X-Spam-Score: -2.9 (--) X-IsSubscribed: yes Mailing-List: contact mauve-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: mauve-discuss-owner@sourceware.org X-SW-Source: 2011-q3/txt/msg00025.txt.bz2 On Wed, 2011-09-14 at 10:57 +0200, Pavel Tisnovsky wrote: > here's the new version of a patch for a Mauve test > javax/swing/Border/TitledBorder/constructors.java. This patch make this t= est > work correctly on OpenJDK & GNU Classpath too: IMHO you just found a bug in GNU Classpath. If no position is given it should use DEFAULT_POSITION, not TOP. The test was wrong, and I think your original fix was correct. Cheers, Mark