From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19058 invoked by alias); 14 Apr 2004 09:56:56 -0000 Mailing-List: contact mauve-discuss-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: mauve-discuss-owner@sources.redhat.com Received: (qmail 19051 invoked from network); 14 Apr 2004 09:56:55 -0000 Received: from unknown (HELO cuddles.cambridge.redhat.com) (81.96.64.123) by sources.redhat.com with SMTP; 14 Apr 2004 09:56:55 -0000 Received: from redhat.com (localhost.localdomain [127.0.0.1]) by cuddles.cambridge.redhat.com (8.12.8/8.12.8) with ESMTP id i3E9tnP0012962; Wed, 14 Apr 2004 10:55:59 +0100 Received: (from aph@localhost) by redhat.com (8.12.8/8.12.8/Submit) id i3E9tmwd012958; Wed, 14 Apr 2004 10:55:48 +0100 From: Andrew Haley MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-ID: <16509.2724.862124.386156@cuddles.cambridge.redhat.com> Date: Wed, 14 Apr 2004 09:56:00 -0000 To: Thomas Zander Cc: mauve-discuss@sources.redhat.com Subject: Re: Mauve patches. In-Reply-To: <200404132058.37587.zander@javalobby.org> References: <200404060956.14298.zander@javalobby.org> <200404131913.49935.zander@javalobby.org> <16508.9997.393675.283091@cuddles.cambridge.redhat.com> <200404132058.37587.zander@javalobby.org> X-SW-Source: 2004-q2/txt/msg00033.txt.bz2 Thomas Zander writes: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On Tuesday 13 April 2004 19:44, Andrew Haley wrote: > > I have attached a version here, FYI. > > > > I don't think I've broken anything with the checkin, but please check. > > Hmm; I'm wondering what was wrong with the last patch I sent; the only > difference I see is that I failed to mention the new method in > SimpleTestHarness, and the change in statics in > SimpleDateFormat/attribute.java. This is what you sent: diff -U3 -p -N -r mauve-orig/ChangeLog mauve/ChangeLog --- mauve-orig/ChangeLog 2004-04-03 17:59:25.000000000 +0200 +++ mauve/ChangeLog 2004-04-03 17:54:08.000000000 +0200 @@ -1,4 +1,17 @@ +2004-04-03 Thomas Zander + + * new files + gnu/testlet/javax/swing/JLabel/Icon.java, + gnu/testlet/javax/swing/JLabel/Mnemonic.java + +2004-04-03 Thomas Zander + + * added an ant build option so the autotools are not needed if you use + a fully functional JVM (for example for writing tests). + build.xml: ant build file + gnu/anttask/RunTests.java: ant task for calling SimpleTestHarness.java + This is what I did to make it right: 2004-04-13 Thomas Zander * build.xml: New file. * gnu/anttask/RunTests.java: New file. * gnu/testlet/SimpleTestHarness.java (getFailures): New method. * gnu/testlet/javax/swing/JLabel/Icon.java: New file. * gnu/testlet/javax/swing/JLabel/Mnemonic.java: New file. * gnu/testlet/java/text/SimpleDateFormat/attribute.java (test_FieldPos): Locals no longer static. See http://www.gnu.org/prep/standards_42.html#SEC42. Note in particular that Change Logs document only what, not why. Explanations should be comments in the program. > Was it a bad choice to sent it as a bzip2 compressed patch? Not always, but it does mean that reviewers are less likely to look at your patch straight away. > Anyway; you forgot this thingy: > > diff -U3 -p -N -r mauve-orig/.cvsignore mauve-new/.cvsignore Ah, yes. Thanks. Andrew.