public inbox for mauve-discuss@sourceware.org
 help / color / mirror / Atom feed
From: Andrew Haley <aph@redhat.com>
To: Thomas Zander <zander@javalobby.org>
Cc: mauve-discuss@sources.redhat.com
Subject: patch committal.
Date: Sun, 02 May 2004 12:50:00 -0000	[thread overview]
Message-ID: <16532.61022.809686.215004@cuddles.cambridge.redhat.com> (raw)
In-Reply-To: <200405021416.35670.zander@javalobby.org>

Thomas Zander writes:
 > -----BEGIN PGP SIGNED MESSAGE-----
 > Hash: SHA1
 > 
 > I'm (again) feeling a tad frustrated that nobody is available to commit or 
 > even comment on my patches.
 > http://sources.redhat.com/ml/mauve-discuss/2004-q2/msg00050.html
 > http://sources.redhat.com/ml/mauve-discuss/2004-q2/msg00051.html

There are okay, I think.

 > I've requested a cvs account several times; but have not even
 > received the courtesy of a yes/no answer.

We should get you a CVS account.  However, your opinion that "its more
important to have people creating patches and moving the project
forward then to always have a 100% correct CVS" makes people worried.

 > Any suggestions on how to get this to move forward again? I have a
 > (graphical) redisign for the website here, I started some tests,
 > but all in all it just does not seem worth it if the reply-cycle is
 > this long.
 > 
 > I'm just about ready to give up here..

You should get CVS access, I think, but of course you'll still need to
post patches here for pre-commit discussion.  Everybody does that.

There were problems with your patches. I fixed the problems by hand.
Please don't provide he ChangeLog as a diff: it won't apply anyway.  I
have committed both these patches.  Please check they're OK.

Andrew.

 $ patch -p0 < ~/zander.1 
patching file `ChangeLog'
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to ChangeLog.rej
patching file `gnu/testlet/java/beans/Introspector/jdk12.java'
patching file `gnu/testlet/java/security//AlgorithmParameterGenerator/MauveAlgorithm.java'
patching file `gnu/testlet/java/security//AlgorithmParameters/MauveAlgorithm.java'
patching file `gnu/testlet/java/security//KeyFactory/MauveAlgorithm.java'
patching file `gnu/testlet/java/security//KeyPairGenerator/MauveAlgorithm.java'

 $ patch -p0 < ~/zander.2 
patching file `ChangeLog'
patch: **** malformed patch at line 91: Index: build.xml

  reply	other threads:[~2004-05-02 12:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-02 12:17 Thomas Zander
2004-05-02 12:50 ` Andrew Haley [this message]
2004-05-02 15:05   ` Thomas Zander
2004-05-02 23:49     ` C. Brian Jones
2004-05-04 10:27     ` Andrew Haley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16532.61022.809686.215004@cuddles.cambridge.redhat.com \
    --to=aph@redhat.com \
    --cc=mauve-discuss@sources.redhat.com \
    --cc=zander@javalobby.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).