From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4375 invoked by alias); 25 Nov 2005 19:28:29 -0000 Received: (qmail 4365 invoked by uid 22791); 25 Nov 2005 19:28:28 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 25 Nov 2005 19:28:27 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id jAPJSPht009952 for ; Fri, 25 Nov 2005 14:28:26 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id jAPJSKV07723; Fri, 25 Nov 2005 14:28:20 -0500 Received: from localhost.localdomain.redhat.com (vpn50-55.rdu.redhat.com [172.16.50.55]) by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id jAPJSIgB021173; Fri, 25 Nov 2005 14:28:19 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17287.25388.605383.259537@localhost.localdomain> Date: Fri, 25 Nov 2005 19:28:00 -0000 To: Edwin Steiner Cc: mauve-discuss@sources.redhat.com Subject: Re: inconsistent test names In-Reply-To: <20051118190804.GA10989@localhost.localdomain> References: <20051118190804.GA10989@localhost.localdomain> From: Tom Tromey Reply-To: tromey@redhat.com X-Attribution: Tom X-IsSubscribed: yes Mailing-List: contact mauve-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: mauve-discuss-owner@sourceware.org X-SW-Source: 2005-q4/txt/msg00039.txt.bz2 >>>>> "Edwin" == Edwin Steiner writes: Edwin> One problem I've run accross is that some mauve tests use Edwin> inconsistent names to report PASSes and FAILs. The most troublesome Edwin> cases are those, where a *named* check/fail is followed by an Edwin> *unnamed* one. For example: Yeah, this is a problem. It is kind of a pain to write this correctly. I wonder if we should just give up on the current scheme and do what was suggested years ago, namely just name the test case after the .class, and do a single big pass/fail for the entire file as a whole. Then we would be guaranteed that the test names would be stable (as stable as the file names). We could still track down failures by passing a special flag that would make Mauve dump a stack trace on a failing check(). If compiled with debugging this would give the line number -- which would be even more convenient than what we do now. Thoughts? Tom