From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28652 invoked by alias); 12 Oct 2004 09:41:36 -0000 Mailing-List: contact mauve-discuss-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: mauve-discuss-owner@sources.redhat.com Received: (qmail 28643 invoked from network); 12 Oct 2004 09:41:35 -0000 Received: from unknown (HELO mail5.ewetel.de) (212.6.122.32) by sourceware.org with SMTP; 12 Oct 2004 09:41:35 -0000 Received: from majestix.konqueror.de (dynadsl-080-228-95-116.ewetel.net [80.228.95.116]) by mail5.ewetel.de (8.12.1/8.12.9) with ESMTP id i9C9fWIV003143; Tue, 12 Oct 2004 11:41:32 +0200 (MEST) Received: from [192.168.1.1] (helo=miraculix.konqueror.de) by majestix.konqueror.de with esmtp (Exim 4.34) id 1CHJ9w-0001Ro-Fd; Tue, 12 Oct 2004 11:41:32 +0200 From: Michael Koch To: "Jeroen Frijters" Subject: Re: java.util.Date mess Date: Tue, 12 Oct 2004 09:41:00 -0000 User-Agent: KMail/1.6.2 Cc: , "Mauve Discuss" References: In-Reply-To: MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <200410121141.31542.konqueror@gmx.de> X-CheckCompat: OK X-SW-Source: 2004-q4/txt/msg00012.txt.bz2 On Tuesday 12 October 2004 11:35, Jeroen Frijters wrote: > Michael Koch wrote: > > On Monday 11 October 2004 15:39, Jeroen Frijters wrote: > > > I have some code that depends on unspecified behavior of > > > java.util.Date. In the Sun JDK if you pass out of range > > > parameters to the Date constructors that take year, month, > > > date, etc. it will automatically convert to a valid date (for > > > example, new Date(104, 8, 41) is Oct 11, 2004.) > > > > > > I have a rather lame patch that addresses this (see below), > > > would anyone object to this? > > > > Are there mauve test that confirm that this breaks nothing ? > > I made a new Mauve test (attached) that works better with my patch > (after I fixed one error in my patch and fixed an additional Date > bug), but it still fails on three tests. One is due to a bug in > GregorianCalendar and I haven't investigated the other two. > > Is the attached test OK to commit? Do I need to modify any other > Mauve files to add the test? Just add the file with a proper ChangeLog entry and be done. Thats all you need to do. Thanks for the testcase. Michael