From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7328 invoked by alias); 9 Feb 2005 09:36:17 -0000 Mailing-List: contact mauve-discuss-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: mauve-discuss-owner@sources.redhat.com Received: (qmail 7068 invoked from network); 9 Feb 2005 09:36:03 -0000 Received: from unknown (HELO kiev.dev.factotummedia.nl) (195.18.123.2) by sourceware.org with SMTP; 9 Feb 2005 09:36:03 -0000 Received: from amavis by kiev.dev.factotummedia.nl with scanned-ok (Exim 3.35 #1 (Debian)) id 1CyoGP-0008MC-00; Wed, 09 Feb 2005 10:36:01 +0100 Received: from kiev.dev.factotummedia.nl ([127.0.0.1]) by localhost (kiev [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 31950-04; Wed, 9 Feb 2005 10:36:01 +0100 (CET) Received: from zander by kiev.dev.factotummedia.nl with local (Exim 3.35 #1 (Debian)) id 1CyoGP-0008M4-00; Wed, 09 Feb 2005 10:36:01 +0100 Date: Wed, 09 Feb 2005 09:36:00 -0000 To: Jeroen Frijters Cc: mauve-discuss@sources.redhat.com Subject: Re: New runner Message-ID: <20050209093601.GA31991@factotummedia.nl> References: Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="mP3DRpeJDSE+ciuQ" Content-Disposition: inline In-Reply-To: From: Thomas Zander X-SW-Source: 2005-q1/txt/msg00025.txt.bz2 --mP3DRpeJDSE+ciuQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 2408 On Wed, Feb 09, 2005 at 10:25:03AM +0100, Jeroen Frijters wrote: > Thomas Zander wrote: > > Hi, Jeroen. Thanks for your reply. > > I've just looked into this; when I delete the config and the > > SimpleTestHarness I get compile errors in (only) 9 tests. > > The following are easy to fix and run correctly with some=20 > > modifications > > (read: removal of the cast): > > gnu/testlet/java/io/FileDescriptor/jdk11.java > > gnu/testlet/java/io/FileReader/jdk11.java > > gnu/testlet/java/io/FileWriter/jdk11.java > > gnu/testlet/java/io/RandomAccessFile/jdk11.java > >=20 > > These are a bit more difficult; but I believe them to be=20 > > broken by design or not usable for a 'java -jar' kind of > > test anyway. > > I'll be more specific: > > These 4 tests each test some socket stuff based completely on the > > assumtion that there is someone (an smtp host) listening on a > > pre-configured host/port. This is quite an assumtion that is not very > > usable in the proposed (portable) test-jar. > > gnu/testlet/java/net/Socket/SocketTest.java > > gnu/testlet/java/net/Socket/jdk12.java > > gnu/testlet/java/net/Socket/jdk13.java > > gnu/testlet/java/net/Socket/jdk14.java >=20 > I don't think they're inherently unusable from a jar, I'd like to see a > gnu.testlet.config version that reads the settings from a properties > file (or whatever) instead of hardcoding them in the auto dance. The way the config settings are shipped is not the issue here; the question where a socket can connect to that is reachable from the testing machine so the test does not fail because of wrong reasons is a bigger problem. And the one I tried to list above. When we solve that issue then we can think about how to config it. I have no idea how to do so; so I'm open to suggestions! > > The following test tests things like being able to open a=20 > > file we ship in mauve (in the same package) and other stuff thats > > really really basic. (like File.seperator) Quite useless to test > > in an environment that is shipped in a jar :-) > > gnu/testlet/java/io/File/jdk11.java >=20 > This is more tricky to handle, but hopefully we can figure out a way to > get this test in as well. When we are actually running this test we already did a 'java -jar' and we found several classes in that jar. Does that not imply that the tests in that class will pass? --=20 Thomas Zander --mP3DRpeJDSE+ciuQ Content-Type: application/pgp-signature Content-Disposition: inline Content-length: 189 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.5 (GNU/Linux) iD8DBQFCCdmBCojCW6H2z/QRAmmkAJ9pqvDtig4WPPCaE7cUQD2K78YIvgCgp4uc QsSlxn4jmGj2zM6MrVchGRA= =LrMg -----END PGP SIGNATURE----- --mP3DRpeJDSE+ciuQ--