From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31754 invoked by alias); 29 Nov 2005 15:58:42 -0000 Received: (qmail 31747 invoked by uid 22791); 29 Nov 2005 15:58:41 -0000 X-Spam-Check-By: sourceware.org Received: from gbenson.demon.co.uk (HELO gbenson.demon.co.uk) (80.177.220.214) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 29 Nov 2005 15:58:40 +0000 Received: from slippy.wire.rat ([192.168.1.1]) by gbenson.demon.co.uk with esmtp (Exim 3.36 #1) id 1Eh7sL-0004F5-00 for mauve-discuss@sources.redhat.com; Tue, 29 Nov 2005 15:58:37 +0000 Received: from slippy.wire.rat (localhost.localdomain [127.0.0.1]) by slippy.wire.rat (8.13.1/8.13.1) with ESMTP id jATFwbVE025446 for ; Tue, 29 Nov 2005 15:58:37 GMT Received: (from gary@localhost) by slippy.wire.rat (8.13.1/8.13.1/Submit) id jATFwbdl025445 for mauve-discuss@sources.redhat.com; Tue, 29 Nov 2005 15:58:37 GMT Date: Tue, 29 Nov 2005 15:58:00 -0000 From: Gary Benson To: mauve-discuss@sources.redhat.com Subject: Re: Disabled tests Message-ID: <20051129155837.GD5325@redhat.com> Mail-Followup-To: mauve-discuss@sources.redhat.com References: <20051129135154.GB5325@redhat.com> <1133273779.6994.216.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1133273779.6994.216.camel@localhost.localdomain> X-IsSubscribed: yes Mailing-List: contact mauve-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: mauve-discuss-owner@sourceware.org X-SW-Source: 2005-q4/txt/msg00045.txt.bz2 Mark Wielaard wrote: > On Tue, 2005-11-29 at 13:51 +0000, Gary Benson wrote: > > What do we do with failing tests? > > I think we should have xfail files for them. But currently we don't > really have up to date ones. And in the past various runtimes had > completely different failure behavior making it unclear what the > "correct" xfail file would be. > > I hope the work of Edwin from teh Cacao team will help here since > the produce lists of common failures between runtimes. > > > The reason I ask is that I just noticed that the listRoots test in > > gnu/testlet/java/io/File/security.java has been disabled in a > > totally non-obvious way. Should I reenable it? > > I think so. I have worked on this, but it is so obscure that I > cannot really see the how and what should be happening here. Sorry > about that. In this case there's nothing saying why it's disabled. The initial revision (1.1, July 2003) had the test: it was commented out in the next commit (1.2, March 2004) which was a total rewrite of the whole file. I don't think the test ever passed in Classpath, so it's possible the guy disabled it while he was rewriting and then forgot to reenable it before the commit. The javadoc here makes is pretty clear what needs checking. Does anyone mind if I reenable it? Cheers, Gary