From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9116 invoked by alias); 20 Jan 2006 19:59:54 -0000 Received: (qmail 9108 invoked by uid 22791); 20 Jan 2006 19:59:54 -0000 X-Spam-Check-By: sourceware.org Received: from mail.gmx.de (HELO mail.gmx.net) (213.165.64.21) by sourceware.org (qpsmtpd/0.31) with SMTP; Fri, 20 Jan 2006 19:59:52 +0000 Received: (qmail invoked by alias); 20 Jan 2006 19:59:49 -0000 Received: from 85-124-81-219.dynamic.xdsl-line.inode.at (EHLO yukon) [85.124.81.219] by mail.gmx.net (mp036) with SMTP; 20 Jan 2006 20:59:49 +0100 X-Authenticated: #9981821 Received: by yukon (Postfix, from userid 1000) id 698F95543BD; Fri, 20 Jan 2006 20:59:47 +0100 (CET) Date: Fri, 20 Jan 2006 19:59:00 -0000 From: Edwin Steiner To: mauve-discuss@sourceware.org Subject: misleading output "PASS: Error: ..." Message-ID: <20060120195947.GA8058@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.9i X-Y-GMX-Trusted: 0 X-IsSubscribed: yes Mailing-List: contact mauve-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: mauve-discuss-owner@sourceware.org X-SW-Source: 2006-q1/txt/msg00015.txt.bz2 Hallo! During my work with tgolem I found many lines in the mauve output like this: PASS: gnu.testlet.java.lang.Byte.ByteTest: Error: test_Basics failed - 1 (number 1) They are produced by such code: harness.check(!( Byte.MIN_VALUE != -128 ), "Error: test_Basics failed - 1" ); Would you accept patches turning this into harness.check(!( Byte.MIN_VALUE != -128 ), "test_Basics - 1" ); ? (Only changing the string. Changing the double negation seems too error prone for the many cases I found.) BTW I already promised patches for a similar problem. Unfortunately I had very little spare time recently. I hope this will get better now. Cheers, -Edwin