From: Dr Andrew John Hughes <ahughes@redhat.com>
To: Pavel Tisnovsky <ptisnovs@redhat.com>
Cc: mauve-discuss@sourceware.org
Subject: Re: Fix for test gnu/testlet/java/io/File/security.java
Date: Tue, 16 Aug 2011 13:34:00 -0000 [thread overview]
Message-ID: <20110816133406.GF16879@rivendell.middle-earth.co.uk> (raw)
In-Reply-To: <4E4A5916.7020604@redhat.com>
On 13:48 Tue 16 Aug , Pavel Tisnovsky wrote:
> Greetings,
>
> I'd like to fix the Mauve test "gnu/testlet/java/io/File/security.java" to
> properly close & delete all its work files and directories in the right order.
>
> The fix is very simple:
>
>
> --- mauve/gnu/testlet/java/io/File/security.java 2010-11-15
> 21:56:26.000000000 +0100
> +++ mauve/gnu/testlet/java/io/File/security.java 2011-08-12
> 17:15:54.000000000 +0200
> @@ -526,8 +526,9 @@
> if (tmpfile2 != null) tmpfile2.delete();
> if (tf1 != null) tf1.delete();
> if (tf2 != null) tf2.delete();
> - if (tmpdir != null) tmpdir.delete();
> + if (tmpdir3 != null) tmpdir3.delete();
> if (tmpdir2 != null) tmpdir2.delete();
> + if (tmpdir != null) tmpdir.delete();
> }
> }
> }
>
>
> Is it possible to push this fix to CVS please?
>
> Thank you in advance,
> Pavel Tisnovsky
Yes, looks fine.
--
Andrew :)
Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)
Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D 0698 0713 C3ED F586 2A37
prev parent reply other threads:[~2011-08-16 13:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-16 11:47 Pavel Tisnovsky
2011-08-16 13:34 ` Dr Andrew John Hughes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110816133406.GF16879@rivendell.middle-earth.co.uk \
--to=ahughes@redhat.com \
--cc=mauve-discuss@sourceware.org \
--cc=ptisnovs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).