From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25902 invoked by alias); 16 Aug 2011 13:34:32 -0000 Received: (qmail 25712 invoked by uid 22791); 16 Aug 2011 13:34:32 -0000 X-SWARE-Spam-Status: No, hits=-4.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS,T_HK_NAME_DR X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 16 Aug 2011 13:34:10 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p7GDY9vY030334 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 16 Aug 2011 09:34:09 -0400 Received: from rivendell.middle-earth.co.uk (ovpn-113-48.phx2.redhat.com [10.3.113.48]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p7GDY68N028999 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 16 Aug 2011 09:34:08 -0400 Date: Tue, 16 Aug 2011 13:34:00 -0000 From: Dr Andrew John Hughes To: Pavel Tisnovsky Cc: mauve-discuss@sourceware.org Subject: Re: Fix for test gnu/testlet/java/io/File/security.java Message-ID: <20110816133406.GF16879@rivendell.middle-earth.co.uk> References: <4E4A5916.7020604@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E4A5916.7020604@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact mauve-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: mauve-discuss-owner@sourceware.org X-SW-Source: 2011-q3/txt/msg00001.txt.bz2 On 13:48 Tue 16 Aug , Pavel Tisnovsky wrote: > Greetings, > > I'd like to fix the Mauve test "gnu/testlet/java/io/File/security.java" to > properly close & delete all its work files and directories in the right order. > > The fix is very simple: > > > --- mauve/gnu/testlet/java/io/File/security.java 2010-11-15 > 21:56:26.000000000 +0100 > +++ mauve/gnu/testlet/java/io/File/security.java 2011-08-12 > 17:15:54.000000000 +0200 > @@ -526,8 +526,9 @@ > if (tmpfile2 != null) tmpfile2.delete(); > if (tf1 != null) tf1.delete(); > if (tf2 != null) tf2.delete(); > - if (tmpdir != null) tmpdir.delete(); > + if (tmpdir3 != null) tmpdir3.delete(); > if (tmpdir2 != null) tmpdir2.delete(); > + if (tmpdir != null) tmpdir.delete(); > } > } > } > > > Is it possible to push this fix to CVS please? > > Thank you in advance, > Pavel Tisnovsky Yes, looks fine. -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and IcedTea http://www.gnu.org/software/classpath http://icedtea.classpath.org PGP Key: F5862A37 (https://keys.indymedia.org/) Fingerprint = EA30 D855 D50F 90CD F54D 0698 0713 C3ED F586 2A37