From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16170 invoked by alias); 7 Sep 2011 02:39:12 -0000 Received: (qmail 16161 invoked by uid 22791); 7 Sep 2011 02:39:11 -0000 X-SWARE-Spam-Status: No, hits=-4.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS,T_HK_NAME_DR X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 07 Sep 2011 02:38:53 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p872crvb000603 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 6 Sep 2011 22:38:53 -0400 Received: from rivendell.middle-earth.co.uk (ovpn-113-67.phx2.redhat.com [10.3.113.67]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p872cofk021073 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 6 Sep 2011 22:38:52 -0400 Date: Wed, 07 Sep 2011 02:39:00 -0000 From: Dr Andrew John Hughes To: Pavel Tisnovsky Cc: mauve-discuss@sourceware.org Subject: Re: RFC: fix for Mauve test javax/swing/Border/TitledBorder/constructors.java Message-ID: <20110907023849.GI19081@rivendell.middle-earth.co.uk> References: <4E60F752.1070308@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E60F752.1070308@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact mauve-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: mauve-discuss-owner@sourceware.org X-SW-Source: 2011-q3/txt/msg00015.txt.bz2 On 17:33 Fri 02 Sep , Pavel Tisnovsky wrote: > Greetings, > > here's fix for another Mauve test. In the test > "javax/swing/Border/TitledBorder/constructors.java" the position of the title in > the border should be compared with the constant TitledBorder.DEFAULT_POSITION, > not with TitledBorder.TOP, at least in cases when following constructors are used: > > TitledBorder(Border border) > TitledBorder(Border border, String title) > TitledBorder(String title) > > (there exist three other constructors where title position can be explicitly > specified, but the fix changes only test cases which use the previous three > constructors). > Can you explain why and note whether this affects current test results? -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and IcedTea http://www.gnu.org/software/classpath http://icedtea.classpath.org PGP Key: F5862A37 (https://keys.indymedia.org/) Fingerprint = EA30 D855 D50F 90CD F54D 0698 0713 C3ED F586 2A37