From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23160 invoked by alias); 7 Sep 2011 15:35:40 -0000 Received: (qmail 23000 invoked by uid 22791); 7 Sep 2011 15:35:38 -0000 X-SWARE-Spam-Status: No, hits=-4.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS,T_HK_NAME_DR X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 07 Sep 2011 15:35:15 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p87FZFws018102 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 7 Sep 2011 11:35:15 -0400 Received: from rivendell.middle-earth.co.uk (ovpn-113-85.phx2.redhat.com [10.3.113.85]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p87FZBid029170 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 7 Sep 2011 11:35:14 -0400 Date: Wed, 07 Sep 2011 15:35:00 -0000 From: Dr Andrew John Hughes To: Pavel Tisnovsky Cc: mauve-discuss@sourceware.org Subject: Re: RFC: fix for Mauve test javax/swing/JTextArea/prefferedSize.java Message-ID: <20110907153511.GA18346@rivendell.middle-earth.co.uk> References: <4E60E586.1010600@redhat.com> <20110902150332.GC19081@rivendell.middle-earth.co.uk> <4E60F1A3.1080909@redhat.com> <20110907023910.GJ19081@rivendell.middle-earth.co.uk> <4E6756FC.6010701@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E6756FC.6010701@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact mauve-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: mauve-discuss-owner@sourceware.org X-SW-Source: 2011-q3/txt/msg00019.txt.bz2 On 13:35 Wed 07 Sep , Pavel Tisnovsky wrote: > Dr Andrew John Hughes wrote: > > On 17:09 Fri 02 Sep , Pavel Tisnovsky wrote: > >> Dr Andrew John Hughes wrote: > >>> On 16:17 Fri 02 Sep , Pavel Tisnovsky wrote: > >>>> Greetings, > >>>> > >>>> I think that the last 6 checks contained in Mauve test > >>>> "javax/swing/JTextArea/prefferedSize.java" should be changed. In the original > >>>> test, the preferred width of the JTextArea is compared with 100 pixels after > >>>> word line wrapping is enabled. > >>>> > >>>> But it does not make sense (IMHO) because the JTextArea contains only empty text > >>>> or some NL characters ('\n'), which means, that preferred and minimum width of > >>>> JTextArea should be 0 pixels, not 100 in both cases because empty text and NL > >>>> sequence has only some non-zero height, but zero width. This behaviour is > >>>> independent of auto wrapping and/or word wrapping. > >>>> > >>>> It's probably worth to add some check for preferred height. > >>>> > >>>> Here is proposed change to this test: > >>>> > >>>> --- preferredSize.java 2005-12-07 20:23:38.000000000 +0100 > >>>> +++ prefferedsize.java 2011-09-02 16:02:00.000000000 +0200 > >>>> @@ -51,14 +51,14 @@ > >>>> ta2.setLineWrap(true); > >>>> ta2.setWrapStyleWord(true); > >>>> > >>>> - harness.check (ta2.getPreferredSize().width == 100); > >>>> - harness.check (view.getPreferredSpan(View.HORIZONTAL) == 100); > >>>> + harness.check (ta2.getPreferredSize().width == 0); > >>>> + harness.check (view.getPreferredSpan(View.HORIZONTAL) == 0); > >>>> ta2.setText(""); > >>>> - harness.check (ta2.getPreferredSize().width == 100); > >>>> - harness.check (view.getPreferredSpan(View.HORIZONTAL) == 100); > >>>> + harness.check (ta2.getPreferredSize().width == 0); > >>>> + harness.check (view.getPreferredSpan(View.HORIZONTAL) == 0); > >>>> ta2.setText("\n\n\n\n\n\n\n\n\n"); > >>>> - harness.check (ta2.getPreferredSize().width == 100); > >>>> - harness.check (view.getPreferredSpan(View.HORIZONTAL) == 100); > >>>> + harness.check (ta2.getPreferredSize().width == 0); > >>>> + harness.check (view.getPreferredSpan(View.HORIZONTAL) == 0); > >>>> } > >>>> catch (Exception e) > >>>> { > >>>> ~ > >>>> > >>>> Is it possible to change this test case please? > >>>> > >>>> Cheers, > >>>> Pavel > >>> Do tests still pass with these changes? > >> yes > > > > On both OpenJDK and GNU Classpath? > > They pass only on OpenJDK. On GNU Classpath (4.4.4), some tests failed > regardless of whether the patch has been applied or not. But the failures > occurred on previous test not touched by the patch: > > ta2.setText(""); > harness.check (ta2.getPreferredSize().width == 0); > harness.check (view.getPreferredSpan(View.HORIZONTAL) == 0); > ta2.setText("\n\n\n\n\n\n\n\n\n"); > harness.check (ta2.getPreferredSize().width == 0); > harness.check (view.getPreferredSpan(View.HORIZONTAL) == 0); > > before the line wrap & word wrap is enabled. > > The proposed patch fixes other failures on OpenJDK & GNU Classpath too, ie: > OpenJDK: 6 failures -> 0 failures > GNU Classpath: 8 failures -> 2 failures > > Pavel You seem to have sent this twice... I guess this is ok, but I have to admit I don't really know this GUI stuff that well. Would be good if someone else could take a look. -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and IcedTea http://www.gnu.org/software/classpath http://icedtea.classpath.org PGP Key: F5862A37 (https://keys.indymedia.org/) Fingerprint = EA30 D855 D50F 90CD F54D 0698 0713 C3ED F586 2A37