From: Dr Andrew John Hughes <ahughes@redhat.com>
To: Pavel Tisnovsky <ptisnovs@redhat.com>
Cc: Andii Hughes <gnu_andrew@member.fsf.org>, mauve-discuss@sourceware.org
Subject: Re: RFC: Adding support for a new tag to a Mauve test tool
Date: Mon, 16 Jan 2012 15:46:00 -0000 [thread overview]
Message-ID: <20120116154542.GB1352@rivendell.middle-earth.co.uk> (raw)
In-Reply-To: <4F13EC5A.5070203@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 2449 bytes --]
On 10:22 Mon 16 Jan , Pavel Tisnovsky wrote:
> Andii Hughes wrote:
> > On Jan 13, 2012 11:55 AM, "Pavel Tisnovsky" <ptisnovs@redhat.com
> > <mailto:ptisnovs@redhat.com>> wrote:
> >>
> >> Hi all,
> >>
> >> I'd like to add support for a new tag to a Mauve test tool. This tag
> > is named "CompileOptions:"
> >> and could be used to add specific command line options passed to a
> > compiler (it's different
> >> behavior from changing compiler options globally).
> >>
> >> Usage (in the test - btw: its compatible with ECJ and OpenJDK too):
> >>
> >> // Tags: CompileOptions: -source 1.4
> >>
> >> or just:
> >>
> >> // CompileOptions: -source 1.4
> >>
> >> because the "Tags:" prefix is not checked (it's true for other tags
> > too - I'm not sure if its
> >> a bug or a feature of Mauve test tool :-).
> >>
> >> Unified diff for Harness.java is stored in an attachment.
> >>
> >> Could anybody look at this change please?
> >>
> >
> > I've no objection to the change as it stands, but I seem to remember
> > there already being support for handling different Java versions (at
> > least, I remember writing versions in comments). Have you checked there
> > isn't already a way of doing this?
>
> Hi Andrew,
>
> partially yes, it's possible to specify target JDK version in a tag.
> For example:
> // Tags: JDK1.4
>
> (and I'm glad this tag exists due to changes in standard API)
>
> But this tag is not used by the Harness tool itself. It's supported only
> by Ant-related tool which can select (filter/grep) only the tests
> with specified JDK versions and compile/run them. But even if the test
> is select by this Ant-tool, there's no way (AFAIK) how to specify
> command line flags passed to the compiler. But in some (minor) cases
> it's useful to be able to specify -source, -target, -bootclasspath or
> something similar.
>
> Btw: The mentioned Ant-tool (or are such thing called "plugin"?) is stored
> in mauve/gnu/anttask
>
> >
> >> Thank you in advance,
> >> Pavel
> >
>
Ok, if there are cases other than source/target, then it makes sense to
have a general 'append to command-line' option. I was just checking we
wouldn't end up with duplicate features.
--
Andrew :)
Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)
PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-01-16 15:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-13 11:55 Pavel Tisnovsky
[not found] ` <CAFXTvn5xZ8h_yvirEqSkcpDjOPN3gFP2fWiENWzNTh=nQwDWAA@mail.gmail.com>
2012-01-16 9:20 ` Pavel Tisnovsky
2012-01-16 15:46 ` Dr Andrew John Hughes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120116154542.GB1352@rivendell.middle-earth.co.uk \
--to=ahughes@redhat.com \
--cc=gnu_andrew@member.fsf.org \
--cc=mauve-discuss@sourceware.org \
--cc=ptisnovs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).