From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16529 invoked by alias); 16 Jan 2012 15:46:07 -0000 Received: (qmail 16507 invoked by uid 22791); 16 Jan 2012 15:46:03 -0000 X-SWARE-Spam-Status: No, hits=-4.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_HK_NAME_DR,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 16 Jan 2012 15:45:48 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q0GFjk8j015164 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 16 Jan 2012 10:45:46 -0500 Received: from rivendell.middle-earth.co.uk (ovpn-113-92.phx2.redhat.com [10.3.113.92]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q0GFjgqK003493 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 16 Jan 2012 10:45:44 -0500 Date: Mon, 16 Jan 2012 15:46:00 -0000 From: Dr Andrew John Hughes To: Pavel Tisnovsky Cc: Andii Hughes , mauve-discuss@sourceware.org Subject: Re: RFC: Adding support for a new tag to a Mauve test tool Message-ID: <20120116154542.GB1352@rivendell.middle-earth.co.uk> References: <0093208b-00bd-470c-9949-7f83c02304d1@zmail14.collab.prod.int.phx2.redhat.com> <4F13EC5A.5070203@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="A6N2fC+uXW/VQSAv" Content-Disposition: inline In-Reply-To: <4F13EC5A.5070203@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact mauve-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: mauve-discuss-owner@sourceware.org X-SW-Source: 2012-q1/txt/msg00002.txt.bz2 --A6N2fC+uXW/VQSAv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 2402 On 10:22 Mon 16 Jan , Pavel Tisnovsky wrote: > Andii Hughes wrote: > > On Jan 13, 2012 11:55 AM, "Pavel Tisnovsky" > > wrote: > >> > >> Hi all, > >> > >> I'd like to add support for a new tag to a Mauve test tool. This tag > > is named "CompileOptions:" > >> and could be used to add specific command line options passed to a > > compiler (it's different > >> behavior from changing compiler options globally). > >> > >> Usage (in the test - btw: its compatible with ECJ and OpenJDK too): > >> > >> // Tags: CompileOptions: -source 1.4 > >> > >> or just: > >> > >> // CompileOptions: -source 1.4 > >> > >> because the "Tags:" prefix is not checked (it's true for other tags > > too - I'm not sure if its > >> a bug or a feature of Mauve test tool :-). > >> > >> Unified diff for Harness.java is stored in an attachment. > >> > >> Could anybody look at this change please? > >> > >=20 > > I've no objection to the change as it stands, but I seem to remember > > there already being support for handling different Java versions (at > > least, I remember writing versions in comments). Have you checked there > > isn't already a way of doing this? >=20 > Hi Andrew, >=20 > partially yes, it's possible to specify target JDK version in a tag. > For example: > // Tags: JDK1.4 >=20 > (and I'm glad this tag exists due to changes in standard API) >=20 > But this tag is not used by the Harness tool itself. It's supported only > by Ant-related tool which can select (filter/grep) only the tests > with specified JDK versions and compile/run them. But even if the test > is select by this Ant-tool, there's no way (AFAIK) how to specify > command line flags passed to the compiler. But in some (minor) cases > it's useful to be able to specify -source, -target, -bootclasspath or > something similar. >=20 > Btw: The mentioned Ant-tool (or are such thing called "plugin"?) is stored > in mauve/gnu/anttask >=20 > >=20 > >> Thank you in advance, > >> Pavel > >=20 >=20 Ok, if there are cases other than source/target, then it makes sense to have a general 'append to command-line' option. I was just checking we wouldn't end up with duplicate features. --=20 Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint =3D EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07 --A6N2fC+uXW/VQSAv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (GNU/Linux) iQIcBAEBCgAGBQJPFEYmAAoJEDuWpXgki9wHIxAQAKY1U3+GONCvkDajQRG/ixiC HS+qrJ8Z1eWauFAIJ+E9TxNG22Ed4PVGujeU8V+vTmrgRFoQuNyP3BlimYUK73yq q7vBczK7OolgNuzQrJQ5FUPzpc/nsyAl8+xjfeZ8CO9u6r/yx8z9MiaMGDjNtWE0 q8kZaJNYzGWaDzPeKzGwDaxKvOlNQAgIFWZtmIPbxM08hT2RT6LD4mDWONqhWgOD 1Ar6rtVCNAmeYFS/tc+qyRpnwsqvN7QGvhSQf/GvWe6wHr5NGBpY3C2CvGI92DSy 0h/poyulyoCdHqKY4H/UZSD10nZAkZkviPx/AFDAm4uk6j7SO+rO91cCjeRuJUtT 3oqcG8hk4prBakxryo/eh7Kw9BF11Vdr02jyQDKoBu/9xNmrxhTekCQlPNugJsAP VcsTQfgWioKlGP8TB9ngFctvw2gBMb+Maxl96fclI9Xt65y6/yIyqLqfejrqxVCv 84ens4HFTr90UEayioXHSakPgyJlIodCLJFJzgMygLyZeLuDVVg6Q86iozueDjYA NKciSMd2l2uF7CaedSEHDpNSsZLxIjysMJslDjK9m0EKEc7gStrBNmr5hmLR40Vh ErO1Mg0jvoThQu9qagKcsfRbRmJpyddO0S0oxTE0OCuJWMRSYNRIeOOdl3pAywMm O38/avT7VGo41dTeVHDB =YxrM -----END PGP SIGNATURE----- --A6N2fC+uXW/VQSAv--