From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mauve-discuss-return-896-listarch-mauve-discuss=sources.redhat.com@sources.redhat.com>
Received: (qmail 16304 invoked by alias); 17 Sep 2005 12:20:33 -0000
Mailing-List: contact mauve-discuss-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:mauve-discuss-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/mauve-discuss/>
List-Post: <mailto:mauve-discuss@sources.redhat.com>
List-Help: <mailto:mauve-discuss-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: mauve-discuss-owner@sources.redhat.com
Received: (qmail 16289 invoked by uid 22791); 17 Sep 2005 12:20:30 -0000
Received: from mla78-1-82-240-16-110.fbx.proxad.net (HELO pcfabien) (82.240.16.110)
    by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Sat, 17 Sep 2005 12:20:30 +0000
Received: from [127.0.0.1] by pcfabien
  (ArGoSoft Mail Server Freeware, Version 1.8 (1.8.7.5)); Sat, 17 Sep 2005 14:19:30 +0200
Message-ID: <432C09CC.3070402@users.sourceforge.net>
Date: Sat, 17 Sep 2005 12:20:00 -0000
From: Fabien DUMINY <fduminy@users.sourceforge.net>
User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206)
MIME-Version: 1.0
To: Michael Koch <konqueror@gmx.de>
CC:  mauve-discuss@sources.redhat.com
Subject: Re: Can I commit a bug fix in CreateTags.java ?
References: <432BFCD0.7030305@laposte.net> <20050917115254.GI19178@asterix.konqueror.de>
In-Reply-To: <20050917115254.GI19178@asterix.konqueror.de>
Content-Type: multipart/mixed;
 boundary="------------030403090702070409040807"
X-SW-Source: 2005-q3/txt/msg00047.txt.bz2

This is a multi-part message in MIME format.
--------------030403090702070409040807
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
Content-length: 571

Michael Koch a écrit :

>On Sat, Sep 17, 2005 at 01:24:00PM +0200, Fabien DUMINY wrote:
>  
>
>>Hi,
>>I found and fixed a bug in CreateTags. The ';' wasn't removed from the package declaration and it 
>>was written in the testlet className.
>>
>>Can I commit the bug fix (when I will have the rights to do) ?
>>I ask you that question because I read that such modification (in the core of Mauve, not in the 
>>testlets) should be discussed here.
>>    
>>
>
>Please send a patch representing this change here.
>
>
>Michael
>  
>
Here is the patch (joined file).

Fabien.

--------------030403090702070409040807
Content-Type: text/plain;
 name="CreateTags_bugfix.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="CreateTags_bugfix.patch"
Content-length: 823

Index: CreateTags.java
===================================================================
RCS file: /cvs/mauve/mauve/gnu/testlet/runner/CreateTags.java,v
retrieving revision 1.1
diff -u -r1.1 CreateTags.java
--- CreateTags.java	1 Jul 2005 18:33:43 -0000	1.1
+++ CreateTags.java	17 Sep 2005 12:14:22 -0000
@@ -130,7 +130,10 @@
                                 tags = line;
                         }
                         else if(buf.indexOf("package ") == 0)
-                            pckage = buf.substring(8, buf.length()-1);
+                        {
+                            int idx = buf.lastIndexOf(";");
+                            pckage = buf.substring(8, idx);
+                        }
                         buf = new StringBuffer();
                         maxLines--;
                     }


--------------030403090702070409040807--