From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28953 invoked by alias); 19 Sep 2005 12:51:27 -0000 Mailing-List: contact mauve-discuss-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: mauve-discuss-owner@sources.redhat.com Received: (qmail 28841 invoked by uid 22791); 19 Sep 2005 12:51:19 -0000 Received: from outmail128177.authsmtp.com (HELO squirrel.dmpriest.net.uk) (62.13.128.177) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 19 Sep 2005 12:51:19 +0000 Received: from [82.5.12.149] (cpc2-hem14-6-0-cust149.lutn.cable.ntl.com [82.5.12.149]) (authenticated bits=0) by squirrel.dmpriest.net.uk (8.13.3/8.13.3/Kp) with ESMTP id j8JCpAlT052066; Mon, 19 Sep 2005 13:51:10 +0100 (BST) (envelope-from david.gilbert@object-refinery.com) Message-ID: <432EC250.7070708@object-refinery.com> Date: Mon, 19 Sep 2005 12:51:00 -0000 From: David Gilbert User-Agent: Mozilla Thunderbird 1.0.6 (X11/20050728) MIME-Version: 1.0 To: Fabien DUMINY CC: Michael Koch , mauve-discuss@sources.redhat.com Subject: Re: Can I commit a bug fix in CreateTags.java ? References: <432BFCD0.7030305@laposte.net> <20050917115254.GI19178@asterix.konqueror.de> <432C09CC.3070402@users.sourceforge.net> In-Reply-To: <432C09CC.3070402@users.sourceforge.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-Server-Quench: 0dd0e8b0-290c-11da-a87f-001185d377ca X-Authentic-SMTP: 61633132333134.squirrel.dmpriest.net.uk:1.38/Kp X-Powered-By: AuthSMTP - http://www.authsmtp.com - Authenticated SMTP Mail Relay X-Report-SPAM: If SPAM / abuse - report it at: http://www.authsmtp.com/abuse X-Virus-Status: No virus detected - but ensure you scan with your own anti-virus system! X-SW-Source: 2005-q3/txt/msg00050.txt.bz2 Fabien DUMINY wrote: > Michael Koch a écrit : > >> On Sat, Sep 17, 2005 at 01:24:00PM +0200, Fabien DUMINY wrote: >> >> >>> Hi, >>> I found and fixed a bug in CreateTags. The ';' wasn't removed from >>> the package declaration and it was written in the testlet className. >>> >>> Can I commit the bug fix (when I will have the rights to do) ? >>> I ask you that question because I read that such modification (in >>> the core of Mauve, not in the testlets) should be discussed here. >>> >> >> >> Please send a patch representing this change here. >> >> >> Michael >> >> > Here is the patch (joined file). > > Fabien. > >------------------------------------------------------------------------ > >Index: CreateTags.java >=================================================================== >RCS file: /cvs/mauve/mauve/gnu/testlet/runner/CreateTags.java,v >retrieving revision 1.1 >diff -u -r1.1 CreateTags.java >--- CreateTags.java 1 Jul 2005 18:33:43 -0000 1.1 >+++ CreateTags.java 17 Sep 2005 12:14:22 -0000 >@@ -130,7 +130,10 @@ > tags = line; > } > else if(buf.indexOf("package ") == 0) >- pckage = buf.substring(8, buf.length()-1); >+ { >+ int idx = buf.lastIndexOf(";"); >+ pckage = buf.substring(8, idx); >+ } > buf = new StringBuffer(); > maxLines--; > } > > I ran the CreateTags program (for the first time) and didn't see a problem. Here's the first few lines of the output file: [JDK1.0] gnu.testlet.java.io.LineNumberInputStream.Test gnu.testlet.java.io.FilterInputStream.MarkReset gnu.testlet.java.io.FilterInputStream.SimpleRead gnu.testlet.java.io.BufferedInputStream.ProtectedVars gnu.testlet.java.io.BufferedInputStream.MarkReset gnu.testlet.java.io.BufferedInputStream.ZeroRead gnu.testlet.java.io.BufferedInputStream.BigMark gnu.testlet.java.io.BufferedInputStream.SimpleRead What do you get when you run it? What are you running it with? (I tried both JamVM with Classpath CVS and Sun's JDK1.4.2_08 on GNU Linux). Regards, Dave