From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7461 invoked by alias); 27 Sep 2005 08:53:04 -0000 Mailing-List: contact mauve-discuss-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: mauve-discuss-owner@sources.redhat.com Received: (qmail 7449 invoked by uid 22791); 27 Sep 2005 08:52:59 -0000 Received: from outmail128181.authsmtp.net (HELO squirrel.dmpriest.net.uk) (62.13.128.181) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Tue, 27 Sep 2005 08:52:59 +0000 Received: from [82.5.12.149] (cpc2-hem14-6-0-cust149.lutn.cable.ntl.com [82.5.12.149]) (authenticated bits=0) by squirrel.dmpriest.net.uk (8.13.3/8.13.3/Kp) with ESMTP id j8R8qtl8018275; Tue, 27 Sep 2005 09:52:55 +0100 (BST) (envelope-from david.gilbert@object-refinery.com) Message-ID: <4339167B.1000105@object-refinery.com> Date: Tue, 27 Sep 2005 08:53:00 -0000 From: David Gilbert User-Agent: Mozilla Thunderbird 1.0.6 (X11/20050728) MIME-Version: 1.0 To: Torben.Nielsen@sagemdenmark.dk CC: mauve-discuss@sourceware.org, thebohemian@gmx.net Subject: Re: Bug in getEncoding testcase References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Server-Quench: 18b707db-2f34-11da-a87f-001185d377ca X-Authentic-SMTP: 61633132333134.squirrel.dmpriest.net.uk:1.38/Kp X-Powered-By: AuthSMTP - http://www.authsmtp.com - Authenticated SMTP Mail Relay X-Report-SPAM: If SPAM / abuse - report it at: http://www.authsmtp.com/abuse X-Virus-Status: No virus detected - but ensure you scan with your own anti-virus system! X-SW-Source: 2005-q3/txt/msg00066.txt.bz2 Hi Torben, Thanks for following this up. Robert Schuster wrote the original test so I suggest we ask him to review your patch (I've cc'ed him). Sending the patch to mauve-patches was the right thing to do, it just didn't work out this time (unfortunately). Regards, Dave Gilbert Torben.Nielsen@sagemdenmark.dk wrote: >A few weeks ago I posted this patch to mauve-patches. Since it is still >unchanged in cvs, I would like to ask if I posted to the wrong list, or >if there is a problem with the patch. The problem with the existing >testcase >is that contradictory to the test description in the top of the file, it >requires the extended charsets to be present, causing numerous false error >reports. > >Index: gnu/testlet/java/io/InputStreamReader/getEncoding.java >=================================================================== >RCS file: >/cvs/mauve/mauve/gnu/testlet/java/io/InputStreamReader/getEncoding.java,v >retrieving revision 1.1 >diff -u -F^f -r1.1 getEncoding.java >--- gnu/testlet/java/io/InputStreamReader/getEncoding.java 17 Jun 2005 >01:49:48 -0000 1.1 >+++ gnu/testlet/java/io/InputStreamReader/getEncoding.java 7 Sep 2005 >14:06:06 -0000 >@@ -165,8 +165,8 @@ > } catch (UnsupportedCharsetException uce) { > supported = false; > } >- harness.check(name, extIoNames[i]); >- harness.check(supported, true); >+ if ( supported ) >+ harness.check(name, extIoNames[i]); > } > } > > > > > >