From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29754 invoked by alias); 8 Mar 2006 13:21:38 -0000 Received: (qmail 29736 invoked by uid 22791); 8 Mar 2006 13:21:36 -0000 X-Spam-Check-By: sourceware.org Received: from outmail128154.authsmtp.net (HELO outmail128154.authsmtp.net) (62.13.128.154) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 08 Mar 2006 13:21:35 +0000 Received: from [192.168.1.37] (host217-37-65-246.in-addr.btopenworld.com [217.37.65.246]) (authenticated bits=0) by squirrel.dmpriest.net.uk (8.13.3/8.13.3/Kp) with ESMTP id k28DLN2b050704; Wed, 8 Mar 2006 13:21:23 GMT (envelope-from david.gilbert@object-refinery.com) Message-ID: <440EDA60.10802@object-refinery.com> Date: Wed, 08 Mar 2006 13:21:00 -0000 From: David Gilbert User-Agent: Mozilla Thunderbird 1.0.7 (X11/20051013) MIME-Version: 1.0 To: Dalibor Topic CC: classpath@gnu.org, mauve-discuss@sourceware.org, mauve-patches Subject: Re: Running Mauve tests with JUnit References: <440C6BB8.90002@object-refinery.com> <440EB4B7.1020709@object-refinery.com> <20060308120721.GA7569@pogo.kaffe.org> In-Reply-To: <20060308120721.GA7569@pogo.kaffe.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Server-Quench: 7098dcc5-aea6-11da-84c5-001185d377ca X-Authentic-SMTP: 61633132333134.squirrel.dmpriest.net.uk:1.47/Kp X-Powered-By: AuthSMTP - http://www.authsmtp.com - Authenticated SMTP Mail Relay X-Report-SPAM: If SPAM / abuse - report it at: http://www.authsmtp.com/abuse X-Virus-Status: No virus detected - but ensure you scan with your own anti-virus system! X-IsSubscribed: yes Mailing-List: contact mauve-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: mauve-discuss-owner@sourceware.org X-SW-Source: 2006-q1/txt/msg00054.txt.bz2 Hi Dalibor, I had meant to keep this on the Mauve lists, but I'll reply to the Classpath list also... Dalibor Topic wrote: >On Wed, Mar 08, 2006 at 10:40:55AM +0000, David Gilbert wrote: > > >>I didn't get any feedback about this...anyone think it is a good/bad idea? >> >> >excellent idea in my opinion. Have you looked at graydon's junit mauve >bridge at >http://sources.redhat.com/ml/mauve-discuss/2003-q4/msg00003.html ? > > > I hadn't seen Graydon's bridge class, thanks for the link (and I should do more research next time). Looking over it, it has the advantage that it doesn't require any existing Mauve testlets to be modified (and we have a lot of testlets), but the disadvantage that it doesn't buy you much in terms of integration with IDEs (you still have to generate the test list ['classes'] file, for instance, which is the major stumbling block that people seem to have when trying to run Mauve). By modifying the Mauve testlets in the way that I proposed, you can (for example) run a single test in Eclipse just by selecting the source file and clicking 'Run as --> JUnit test'. I figured that was the sort of thing people were expecting. JUnit does seem to me to be less flexible in terms of selecting subsets of tests, and it's approach of reporting a pass/fail for each test method (only) makes it, in my opinion, less suitable for the type of testing we are doing on GNU Classpath. But I was careful in the "conversion" to retain the Mauve testlets so that we can continue running the tests in the traditional (Mauve) way. >If we do something like that. I'd like to see the junit code from >freenet merged in, to keep it simple to run mauve without external >dependencies. > > Agreed. I didn't have much trouble getting the tests to compile against the freenet code (a basic GPLed implementation of the JUnit API for those that don't know what it is) but didn't get any meaningful output from running the tests against it yet. I don't think that will be too hard to resolve. Regards, Dave