From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17174 invoked by alias); 4 Oct 2007 13:04:04 -0000 Received: (qmail 17151 invoked by uid 22791); 4 Oct 2007 13:04:04 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 04 Oct 2007 13:03:58 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.1) with ESMTP id l94D3u7S007623; Thu, 4 Oct 2007 09:03:56 -0400 Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com [172.16.14.4]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l94D3tfk007281; Thu, 4 Oct 2007 09:03:55 -0400 Received: from [192.168.1.3] (vpn-248-125.boston.redhat.com [10.13.248.125]) by pobox.toronto.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id l94D3nKE019124; Thu, 4 Oct 2007 09:03:52 -0400 Message-ID: <4704E4DA.90900@redhat.com> Date: Thu, 04 Oct 2007 13:04:00 -0000 From: Lillian Angel User-Agent: Thunderbird 2.0.0.6 (Macintosh/20070728) MIME-Version: 1.0 To: =?UTF-8?B?U3RldmUgTWNLYXnimIQ=?= CC: Thomas Fitzsimmons , David Herron , mauve-discuss@sources.redhat.com, Dan Kegel Subject: Re: Tweaking default java.awt.Robot settings References: <4f2ee4520709241331o1a77379cudffb314dc1622914@mail.gmail.com> <46F8238C.8020606@sun.com> <46F95466.7070700@redhat.com> <4f2ee4520709251156yde57b65tbb97032939ac75e6@mail.gmail.com> <46F96854.6080706@redhat.com> <4f2ee4520709251328s388c16ebs46f66ce3232cb48f@mail.gmail.com> <4f2ee4520710031742u7a569385j60bf46067be98359@mail.gmail.com> In-Reply-To: <4f2ee4520710031742u7a569385j60bf46067be98359@mail.gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact mauve-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: mauve-discuss-owner@sourceware.org X-SW-Source: 2007-q4/txt/msg00001.txt.bz2 Looks good, I tested it out and committed it for you: 2007-10-03 Steve McKay * gnu/testlet/java/awt/Component/keyPressTest.java: Fixed test so event is not created and dispatched. Completely waits for the frame to receive and respond keypress events. Lillian Steve McKay☄ wrote: > Here's a patch for the test. Everything seems to be working well. I > haven't looked through the other tests yet to see how this might be > shared. > > --steve > > On 9/25/07, Steve McKay☄ wrote: > >> Thomas, >> >> >>> Even after you've ensured that the frame has responded, subsequent checks will >>> still need to be synchronized, since Robot calls are not synchronous. >>> >> That was just a code snippet to demonstrate how to solve one part of >> the problem. The code that does the actual testing is synchronized on >> the lock as well. But like I said, there were liveness issues. I'll >> try to work those out. Still, I can't honestly say that I'd want to go >> through the same amount of effort for every test involving Robot, so >> this change is sorta speculative rather than practical. >> >> -- >> Steve McKay >> >> > > >