public inbox for mauve-discuss@sourceware.org
 help / color / mirror / Atom feed
* Fix for test gnu/testlet/java/io/File/security.java
@ 2011-08-16 11:47 Pavel Tisnovsky
  2011-08-16 13:34 ` Dr Andrew John Hughes
  0 siblings, 1 reply; 2+ messages in thread
From: Pavel Tisnovsky @ 2011-08-16 11:47 UTC (permalink / raw)
  To: mauve-discuss

Greetings,

I'd like to fix the Mauve test "gnu/testlet/java/io/File/security.java" to
properly close & delete all its work files and directories in the right order.

The fix is very simple:


--- mauve/gnu/testlet/java/io/File/security.java        2010-11-15
21:56:26.000000000 +0100
+++ mauve/gnu/testlet/java/io/File/security.java        2011-08-12
17:15:54.000000000 +0200
@@ -526,8 +526,9 @@
       if (tmpfile2 != null) tmpfile2.delete();
       if (tf1 != null) tf1.delete();
       if (tf2 != null) tf2.delete();
-      if (tmpdir != null) tmpdir.delete();
+      if (tmpdir3 != null) tmpdir3.delete();
       if (tmpdir2 != null) tmpdir2.delete();
+      if (tmpdir != null) tmpdir.delete();
     }
   }
 }


Is it possible to push this fix to CVS please?

Thank you in advance,
Pavel Tisnovsky

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Fix for test gnu/testlet/java/io/File/security.java
  2011-08-16 11:47 Fix for test gnu/testlet/java/io/File/security.java Pavel Tisnovsky
@ 2011-08-16 13:34 ` Dr Andrew John Hughes
  0 siblings, 0 replies; 2+ messages in thread
From: Dr Andrew John Hughes @ 2011-08-16 13:34 UTC (permalink / raw)
  To: Pavel Tisnovsky; +Cc: mauve-discuss

On 13:48 Tue 16 Aug     , Pavel Tisnovsky wrote:
> Greetings,
> 
> I'd like to fix the Mauve test "gnu/testlet/java/io/File/security.java" to
> properly close & delete all its work files and directories in the right order.
> 
> The fix is very simple:
> 
> 
> --- mauve/gnu/testlet/java/io/File/security.java        2010-11-15
> 21:56:26.000000000 +0100
> +++ mauve/gnu/testlet/java/io/File/security.java        2011-08-12
> 17:15:54.000000000 +0200
> @@ -526,8 +526,9 @@
>        if (tmpfile2 != null) tmpfile2.delete();
>        if (tf1 != null) tf1.delete();
>        if (tf2 != null) tf2.delete();
> -      if (tmpdir != null) tmpdir.delete();
> +      if (tmpdir3 != null) tmpdir3.delete();
>        if (tmpdir2 != null) tmpdir2.delete();
> +      if (tmpdir != null) tmpdir.delete();
>      }
>    }
>  }
> 
> 
> Is it possible to push this fix to CVS please?
> 
> Thank you in advance,
> Pavel Tisnovsky

Yes, looks fine.
-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-08-16 13:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-16 11:47 Fix for test gnu/testlet/java/io/File/security.java Pavel Tisnovsky
2011-08-16 13:34 ` Dr Andrew John Hughes

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).