From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27263 invoked by alias); 2 Sep 2011 15:07:43 -0000 Received: (qmail 27253 invoked by uid 22791); 2 Sep 2011 15:07:43 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 02 Sep 2011 15:07:24 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p82F7O2C018986 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 2 Sep 2011 11:07:24 -0400 Received: from dhcp-lab-190.englab.brq.redhat.com (dhcp-2-245.brq.redhat.com [10.34.2.245]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p82F7NBW004863; Fri, 2 Sep 2011 11:07:23 -0400 Message-ID: <4E60F1A3.1080909@redhat.com> Date: Fri, 02 Sep 2011 15:07:00 -0000 From: Pavel Tisnovsky User-Agent: Thunderbird 2.0.0.23 (X11/20090825) MIME-Version: 1.0 To: Dr Andrew John Hughes CC: mauve-discuss@sourceware.org Subject: Re: RFC: fix for Mauve test javax/swing/JTextArea/prefferedSize.java References: <4E60E586.1010600@redhat.com> <20110902150332.GC19081@rivendell.middle-earth.co.uk> In-Reply-To: <20110902150332.GC19081@rivendell.middle-earth.co.uk> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact mauve-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: mauve-discuss-owner@sourceware.org X-SW-Source: 2011-q3/txt/msg00013.txt.bz2 Dr Andrew John Hughes wrote: > On 16:17 Fri 02 Sep , Pavel Tisnovsky wrote: >> Greetings, >> >> I think that the last 6 checks contained in Mauve test >> "javax/swing/JTextArea/prefferedSize.java" should be changed. In the original >> test, the preferred width of the JTextArea is compared with 100 pixels after >> word line wrapping is enabled. >> >> But it does not make sense (IMHO) because the JTextArea contains only empty text >> or some NL characters ('\n'), which means, that preferred and minimum width of >> JTextArea should be 0 pixels, not 100 in both cases because empty text and NL >> sequence has only some non-zero height, but zero width. This behaviour is >> independent of auto wrapping and/or word wrapping. >> >> It's probably worth to add some check for preferred height. >> >> Here is proposed change to this test: >> >> --- preferredSize.java 2005-12-07 20:23:38.000000000 +0100 >> +++ prefferedsize.java 2011-09-02 16:02:00.000000000 +0200 >> @@ -51,14 +51,14 @@ >> ta2.setLineWrap(true); >> ta2.setWrapStyleWord(true); >> >> - harness.check (ta2.getPreferredSize().width == 100); >> - harness.check (view.getPreferredSpan(View.HORIZONTAL) == 100); >> + harness.check (ta2.getPreferredSize().width == 0); >> + harness.check (view.getPreferredSpan(View.HORIZONTAL) == 0); >> ta2.setText(""); >> - harness.check (ta2.getPreferredSize().width == 100); >> - harness.check (view.getPreferredSpan(View.HORIZONTAL) == 100); >> + harness.check (ta2.getPreferredSize().width == 0); >> + harness.check (view.getPreferredSpan(View.HORIZONTAL) == 0); >> ta2.setText("\n\n\n\n\n\n\n\n\n"); >> - harness.check (ta2.getPreferredSize().width == 100); >> - harness.check (view.getPreferredSpan(View.HORIZONTAL) == 100); >> + harness.check (ta2.getPreferredSize().width == 0); >> + harness.check (view.getPreferredSpan(View.HORIZONTAL) == 0); >> } >> catch (Exception e) >> { >> ~ >> >> Is it possible to change this test case please? >> >> Cheers, >> Pavel > > Do tests still pass with these changes? yes