From: Pavel Tisnovsky <ptisnovs@redhat.com>
To: mauve-discuss@sourceware.org
Subject: RFC: fix for Mauve test javax/swing/Border/TitledBorder/constructors.java
Date: Fri, 02 Sep 2011 15:31:00 -0000 [thread overview]
Message-ID: <4E60F752.1070308@redhat.com> (raw)
Greetings,
here's fix for another Mauve test. In the test
"javax/swing/Border/TitledBorder/constructors.java" the position of the title in
the border should be compared with the constant TitledBorder.DEFAULT_POSITION,
not with TitledBorder.TOP, at least in cases when following constructors are used:
TitledBorder(Border border)
TitledBorder(Border border, String title)
TitledBorder(String title)
(there exist three other constructors where title position can be explicitly
specified, but the fix changes only test cases which use the previous three
constructors).
Here's proposed fix for the test:
--- javax/swing/border/Border/TitledBorder/constructors.java 2006-02-01
15:14:22.000000000 +0100
+++ javax/swing/border/Border/TitledBorder/constructors.java 2011-09-02
16:37:19.000000000 +0200
@@ -77,7 +77,7 @@
harness.check(tb.getTitleColor(), c);
Font f = UIManager.getLookAndFeelDefaults().getFont("TitledBorder.font");
harness.check(tb.getTitleFont(), f);
- harness.check(tb.getTitlePosition(), TitledBorder.TOP);
+ harness.check(tb.getTitlePosition(), TitledBorder.DEFAULT_POSITION);
harness.check(tb.getTitleJustification(), TitledBorder.LEADING);
tb = new TitledBorder((Border) null);
@@ -98,7 +98,7 @@
harness.check(tb.getTitleColor(), c);
Font f = UIManager.getLookAndFeelDefaults().getFont("TitledBorder.font");
harness.check(tb.getTitleFont(), f);
- harness.check(tb.getTitlePosition(), TitledBorder.TOP);
+ harness.check(tb.getTitlePosition(), TitledBorder.DEFAULT_POSITION);
harness.check(tb.getTitleJustification(), TitledBorder.LEADING);
tb = new TitledBorder((Border) null, "XYZ");
@@ -202,7 +202,7 @@
harness.check(tb.getTitleColor(), c);
Font f = UIManager.getLookAndFeelDefaults().getFont("TitledBorder.font");
harness.check(tb.getTitleFont(), f);
- harness.check(tb.getTitlePosition(), TitledBorder.TOP);
+ harness.check(tb.getTitlePosition(), TitledBorder.DEFAULT_POSITION);
harness.check(tb.getTitleJustification(), TitledBorder.LEADING);
tb = new TitledBorder((String) null);
~
Can anybody please review this change?
Thank you in advance,
Pavel
next reply other threads:[~2011-09-02 15:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-02 15:31 Pavel Tisnovsky [this message]
2011-09-07 2:39 ` Dr Andrew John Hughes
2011-09-07 12:53 ` Pavel Tisnovsky
2011-09-14 8:55 ` Pavel Tisnovsky
2011-09-14 9:11 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E60F752.1070308@redhat.com \
--to=ptisnovs@redhat.com \
--cc=mauve-discuss@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).