From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2732 invoked by alias); 2 Sep 2011 15:31:57 -0000 Received: (qmail 2722 invoked by uid 22791); 2 Sep 2011 15:31:55 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 02 Sep 2011 15:31:39 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p82FVdbs029012 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 2 Sep 2011 11:31:39 -0400 Received: from dhcp-lab-190.englab.brq.redhat.com (dhcp-2-245.brq.redhat.com [10.34.2.245]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p82FVccs024062 for ; Fri, 2 Sep 2011 11:31:38 -0400 Message-ID: <4E60F752.1070308@redhat.com> Date: Fri, 02 Sep 2011 15:31:00 -0000 From: Pavel Tisnovsky User-Agent: Thunderbird 2.0.0.23 (X11/20090825) MIME-Version: 1.0 To: mauve-discuss@sourceware.org Subject: RFC: fix for Mauve test javax/swing/Border/TitledBorder/constructors.java Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact mauve-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: mauve-discuss-owner@sourceware.org X-SW-Source: 2011-q3/txt/msg00014.txt.bz2 Greetings, here's fix for another Mauve test. In the test "javax/swing/Border/TitledBorder/constructors.java" the position of the title in the border should be compared with the constant TitledBorder.DEFAULT_POSITION, not with TitledBorder.TOP, at least in cases when following constructors are used: TitledBorder(Border border) TitledBorder(Border border, String title) TitledBorder(String title) (there exist three other constructors where title position can be explicitly specified, but the fix changes only test cases which use the previous three constructors). Here's proposed fix for the test: --- javax/swing/border/Border/TitledBorder/constructors.java 2006-02-01 15:14:22.000000000 +0100 +++ javax/swing/border/Border/TitledBorder/constructors.java 2011-09-02 16:37:19.000000000 +0200 @@ -77,7 +77,7 @@ harness.check(tb.getTitleColor(), c); Font f = UIManager.getLookAndFeelDefaults().getFont("TitledBorder.font"); harness.check(tb.getTitleFont(), f); - harness.check(tb.getTitlePosition(), TitledBorder.TOP); + harness.check(tb.getTitlePosition(), TitledBorder.DEFAULT_POSITION); harness.check(tb.getTitleJustification(), TitledBorder.LEADING); tb = new TitledBorder((Border) null); @@ -98,7 +98,7 @@ harness.check(tb.getTitleColor(), c); Font f = UIManager.getLookAndFeelDefaults().getFont("TitledBorder.font"); harness.check(tb.getTitleFont(), f); - harness.check(tb.getTitlePosition(), TitledBorder.TOP); + harness.check(tb.getTitlePosition(), TitledBorder.DEFAULT_POSITION); harness.check(tb.getTitleJustification(), TitledBorder.LEADING); tb = new TitledBorder((Border) null, "XYZ"); @@ -202,7 +202,7 @@ harness.check(tb.getTitleColor(), c); Font f = UIManager.getLookAndFeelDefaults().getFont("TitledBorder.font"); harness.check(tb.getTitleFont(), f); - harness.check(tb.getTitlePosition(), TitledBorder.TOP); + harness.check(tb.getTitlePosition(), TitledBorder.DEFAULT_POSITION); harness.check(tb.getTitleJustification(), TitledBorder.LEADING); tb = new TitledBorder((String) null); ~ Can anybody please review this change? Thank you in advance, Pavel