* Question about the test /gnu/testlet/java/util/Currency/Taiwan.java
@ 2011-08-19 8:38 Pavel Tisnovsky
2011-09-02 14:16 ` Pavel Tisnovsky
2011-09-12 13:41 ` Mark Wielaard
0 siblings, 2 replies; 5+ messages in thread
From: Pavel Tisnovsky @ 2011-08-19 8:38 UTC (permalink / raw)
To: mauve-discuss
Hi,
I think that the number of fraction digits for Taiwan (TWD) currency should be
set to 2, not to 0, according to (for example) these pages:
http://www.londonfx.co.uk/ccylist.html
http://en.wikipedia.org/wiki/ISO_4217
Can I fix it?
Cheers,
Pavel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Question about the test /gnu/testlet/java/util/Currency/Taiwan.java
2011-08-19 8:38 Question about the test /gnu/testlet/java/util/Currency/Taiwan.java Pavel Tisnovsky
@ 2011-09-02 14:16 ` Pavel Tisnovsky
2011-09-12 13:41 ` Mark Wielaard
1 sibling, 0 replies; 5+ messages in thread
From: Pavel Tisnovsky @ 2011-09-02 14:16 UTC (permalink / raw)
To: mauve-discuss
ping:
> Hi,
>
> I think that the number of fraction digits for Taiwan (TWD) currency should be
> set to 2, not to 0, according to (for example) these pages:
>
> http://www.londonfx.co.uk/ccylist.html
> http://en.wikipedia.org/wiki/ISO_4217
>
> Can I fix it?
>
> Cheers,
> Pavel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Question about the test /gnu/testlet/java/util/Currency/Taiwan.java
2011-08-19 8:38 Question about the test /gnu/testlet/java/util/Currency/Taiwan.java Pavel Tisnovsky
2011-09-02 14:16 ` Pavel Tisnovsky
@ 2011-09-12 13:41 ` Mark Wielaard
2011-09-12 14:12 ` Pavel Tisnovsky
1 sibling, 1 reply; 5+ messages in thread
From: Mark Wielaard @ 2011-09-12 13:41 UTC (permalink / raw)
To: Pavel Tisnovsky; +Cc: mauve-discuss
On Fri, 2011-08-19 at 10:40 +0200, Pavel Tisnovsky wrote:
> Hi,
>
> I think that the number of fraction digits for Taiwan (TWD) currency should be
> set to 2, not to 0, according to (for example) these pages:
>
> http://www.londonfx.co.uk/ccylist.html
> http://en.wikipedia.org/wiki/ISO_4217
>
> Can I fix it?
Sure, do you have a patch?
Thanks,
Mark
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Question about the test /gnu/testlet/java/util/Currency/Taiwan.java
2011-09-12 13:41 ` Mark Wielaard
@ 2011-09-12 14:12 ` Pavel Tisnovsky
2011-09-12 15:04 ` Mark Wielaard
0 siblings, 1 reply; 5+ messages in thread
From: Pavel Tisnovsky @ 2011-09-12 14:12 UTC (permalink / raw)
To: Mark Wielaard; +Cc: mauve-discuss
Mark Wielaard wrote:
> On Fri, 2011-08-19 at 10:40 +0200, Pavel Tisnovsky wrote:
>> Hi,
>>
>> I think that the number of fraction digits for Taiwan (TWD) currency should be
>> set to 2, not to 0, according to (for example) these pages:
>>
>> http://www.londonfx.co.uk/ccylist.html
>> http://en.wikipedia.org/wiki/ISO_4217
>>
>> Can I fix it?
>
> Sure, do you have a patch?
>
> Thanks,
>
> Mark
Yes, here is:
diff -u /mauve-orig/mauve/gnu/testlet/java/util/Currency/Taiwan.java
/mauve/mauve/gnu/testlet/java/util/Currency/Taiwan.java
--- /mauve-orig/mauve/gnu/testlet/java/util/Currency/Taiwan.java 2008-07-24
18:02:14.000000000 +0200
+++ /mauve/mauve/gnu/testlet/java/util/Currency/Taiwan.java 2011-09-12
16:07:46.000000000 +0200
@@ -37,7 +37,7 @@
private static final Locale TEST_LOCALE = Locale.TAIWAN;
private static final String ISO4217_CODE = "TWD";
private static final String CURRENCY_SYMBOL = "NT$";
- private static final int FRACTION_DIGITS = 0;
+ private static final int FRACTION_DIGITS = 2;
public void test(TestHarness harness)
{
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Question about the test /gnu/testlet/java/util/Currency/Taiwan.java
2011-09-12 14:12 ` Pavel Tisnovsky
@ 2011-09-12 15:04 ` Mark Wielaard
0 siblings, 0 replies; 5+ messages in thread
From: Mark Wielaard @ 2011-09-12 15:04 UTC (permalink / raw)
To: Pavel Tisnovsky; +Cc: mauve-discuss
On Mon, 2011-09-12 at 16:13 +0200, Pavel Tisnovsky wrote:
> Mark Wielaard wrote:
> > On Fri, 2011-08-19 at 10:40 +0200, Pavel Tisnovsky wrote:
> >> Hi,
> >>
> >> I think that the number of fraction digits for Taiwan (TWD) currency should be
> >> set to 2, not to 0, according to (for example) these pages:
> >>
> >> http://www.londonfx.co.uk/ccylist.html
> >> http://en.wikipedia.org/wiki/ISO_4217
> >>
> >> Can I fix it?
> >
> > Sure, do you have a patch?
> >
> Yes, here is:
>
> diff -u /mauve-orig/mauve/gnu/testlet/java/util/Currency/Taiwan.java
> /mauve/mauve/gnu/testlet/java/util/Currency/Taiwan.java
> --- /mauve-orig/mauve/gnu/testlet/java/util/Currency/Taiwan.java 2008-07-24
> 18:02:14.000000000 +0200
> +++ /mauve/mauve/gnu/testlet/java/util/Currency/Taiwan.java 2011-09-12
> 16:07:46.000000000 +0200
> @@ -37,7 +37,7 @@
> private static final Locale TEST_LOCALE = Locale.TAIWAN;
> private static final String ISO4217_CODE = "TWD";
> private static final String CURRENCY_SYMBOL = "NT$";
> - private static final int FRACTION_DIGITS = 0;
> + private static final int FRACTION_DIGITS = 2;
>
> public void test(TestHarness harness)
> {
Yeah, based on those two documents, that seems the correct patch.
Thanks,
Mark
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-09-12 15:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-19 8:38 Question about the test /gnu/testlet/java/util/Currency/Taiwan.java Pavel Tisnovsky
2011-09-02 14:16 ` Pavel Tisnovsky
2011-09-12 13:41 ` Mark Wielaard
2011-09-12 14:12 ` Pavel Tisnovsky
2011-09-12 15:04 ` Mark Wielaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).