From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30963 invoked by alias); 12 Sep 2011 14:12:00 -0000 Received: (qmail 30949 invoked by uid 22791); 12 Sep 2011 14:11:59 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 12 Sep 2011 14:11:35 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p8CEBWbk027998 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 12 Sep 2011 10:11:32 -0400 Received: from dhcp-lab-190.englab.brq.redhat.com (dhcp-2-245.brq.redhat.com [10.34.2.245]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p8CEBSEg019970; Mon, 12 Sep 2011 10:11:32 -0400 Message-ID: <4E6E138B.2010105@redhat.com> Date: Mon, 12 Sep 2011 14:12:00 -0000 From: Pavel Tisnovsky User-Agent: Thunderbird 2.0.0.23 (X11/20090825) MIME-Version: 1.0 To: Mark Wielaard CC: mauve-discuss@sourceware.org Subject: Re: Question about the test /gnu/testlet/java/util/Currency/Taiwan.java References: <4E4E2166.5020703@redhat.com> <1315834868.3367.5.camel@springer.wildebeest.org> In-Reply-To: <1315834868.3367.5.camel@springer.wildebeest.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact mauve-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: mauve-discuss-owner@sourceware.org X-SW-Source: 2011-q3/txt/msg00022.txt.bz2 Mark Wielaard wrote: > On Fri, 2011-08-19 at 10:40 +0200, Pavel Tisnovsky wrote: >> Hi, >> >> I think that the number of fraction digits for Taiwan (TWD) currency should be >> set to 2, not to 0, according to (for example) these pages: >> >> http://www.londonfx.co.uk/ccylist.html >> http://en.wikipedia.org/wiki/ISO_4217 >> >> Can I fix it? > > Sure, do you have a patch? > > Thanks, > > Mark Yes, here is: diff -u /mauve-orig/mauve/gnu/testlet/java/util/Currency/Taiwan.java /mauve/mauve/gnu/testlet/java/util/Currency/Taiwan.java --- /mauve-orig/mauve/gnu/testlet/java/util/Currency/Taiwan.java 2008-07-24 18:02:14.000000000 +0200 +++ /mauve/mauve/gnu/testlet/java/util/Currency/Taiwan.java 2011-09-12 16:07:46.000000000 +0200 @@ -37,7 +37,7 @@ private static final Locale TEST_LOCALE = Locale.TAIWAN; private static final String ISO4217_CODE = "TWD"; private static final String CURRENCY_SYMBOL = "NT$"; - private static final int FRACTION_DIGITS = 0; + private static final int FRACTION_DIGITS = 2; public void test(TestHarness harness) {