From: Pavel Tisnovsky <ptisnovs@redhat.com>
To: mauve-discuss@sourceware.org
Subject: RFC: fix for two Mauve tests - gnu/testlet/javax/swing/border/TitledBorder/setTitlePosition.java and gnu/testlet/javax/swing/border/TitledBorder/getTitlePosition.java
Date: Thu, 15 Sep 2011 15:03:00 -0000 [thread overview]
Message-ID: <4E721433.7020800@redhat.com> (raw)
Greetings,
I've made patch for two Mauve tests - gnu/testlet/javax/swing/border/TitledBorder/setTitlePosition.java and
gnu/testlet/javax/swing/border/TitledBorder/getTitlePosition.java.
This fix is based on the same issue which was fixed in the test javax/swing/Border/TitledBorder/constructors.java
(discussed here: http://www.cygwin.com/ml/mauve-discuss/2011-q3/msg00014.html)
diff -u -r1.1 getTitlePosition.java
--- gnu/testlet/javax/swing/border/TitledBorder/getTitlePosition.java 10 Oct 2005 08:06:08 -0000 1.1
+++ gnu/testlet/javax/swing/border/TitledBorder/getTitlePosition.java 15 Sep 2011 14:31:44 -0000
@@ -39,7 +39,7 @@
public void test(TestHarness harness)
{
TitledBorder b = new TitledBorder(new EmptyBorder(1, 1, 1, 1));
- harness.check(b.getTitlePosition(), TitledBorder.TOP);
+ harness.check(b.getTitlePosition(), TitledBorder.DEFAULT_POSITION);
b.setTitlePosition(TitledBorder.BELOW_TOP);
harness.check(b.getTitlePosition(), TitledBorder.BELOW_TOP);
}
diff -u -r1.1 setTitlePosition.java
--- gnu/testlet/javax/swing/border/TitledBorder/setTitlePosition.java 10 Oct 2005 08:06:09 -0000 1.1
+++ gnu/testlet/javax/swing/border/TitledBorder/setTitlePosition.java 15 Sep 2011 14:31:44 -0000
@@ -39,7 +39,7 @@
public void test(TestHarness harness)
{
TitledBorder b = new TitledBorder(new EmptyBorder(1, 1, 1, 1));
- harness.check(b.getTitlePosition(), TitledBorder.TOP);
+ harness.check(b.getTitlePosition(), TitledBorder.DEFAULT_POSITION);
b.setTitlePosition(TitledBorder.BELOW_BOTTOM);
harness.check(b.getTitlePosition(), TitledBorder.BELOW_BOTTOM);
boolean pass = false;
Can anybody please review this change?
Cheers
Pavel
reply other threads:[~2011-09-15 15:03 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E721433.7020800@redhat.com \
--to=ptisnovs@redhat.com \
--cc=mauve-discuss@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).