From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11851 invoked by alias); 15 Sep 2011 15:03:42 -0000 Received: (qmail 11829 invoked by uid 22791); 15 Sep 2011 15:03:39 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 15 Sep 2011 15:03:22 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p8FF3MZg003607 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 15 Sep 2011 11:03:22 -0400 Received: from dhcp-lab-190.englab.brq.redhat.com (dhcp-2-245.brq.redhat.com [10.34.2.245]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p8FF3LHE004635 for ; Thu, 15 Sep 2011 11:03:21 -0400 Message-ID: <4E721433.7020800@redhat.com> Date: Thu, 15 Sep 2011 15:03:00 -0000 From: Pavel Tisnovsky User-Agent: Thunderbird 2.0.0.23 (X11/20090825) MIME-Version: 1.0 To: mauve-discuss@sourceware.org Subject: RFC: fix for two Mauve tests - gnu/testlet/javax/swing/border/TitledBorder/setTitlePosition.java and gnu/testlet/javax/swing/border/TitledBorder/getTitlePosition.java Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact mauve-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: mauve-discuss-owner@sourceware.org X-SW-Source: 2011-q3/txt/msg00026.txt.bz2 Greetings, I've made patch for two Mauve tests - gnu/testlet/javax/swing/border/TitledBorder/setTitlePosition.java and gnu/testlet/javax/swing/border/TitledBorder/getTitlePosition.java. This fix is based on the same issue which was fixed in the test javax/swing/Border/TitledBorder/constructors.java (discussed here: http://www.cygwin.com/ml/mauve-discuss/2011-q3/msg00014.html) diff -u -r1.1 getTitlePosition.java --- gnu/testlet/javax/swing/border/TitledBorder/getTitlePosition.java 10 Oct 2005 08:06:08 -0000 1.1 +++ gnu/testlet/javax/swing/border/TitledBorder/getTitlePosition.java 15 Sep 2011 14:31:44 -0000 @@ -39,7 +39,7 @@ public void test(TestHarness harness) { TitledBorder b = new TitledBorder(new EmptyBorder(1, 1, 1, 1)); - harness.check(b.getTitlePosition(), TitledBorder.TOP); + harness.check(b.getTitlePosition(), TitledBorder.DEFAULT_POSITION); b.setTitlePosition(TitledBorder.BELOW_TOP); harness.check(b.getTitlePosition(), TitledBorder.BELOW_TOP); } diff -u -r1.1 setTitlePosition.java --- gnu/testlet/javax/swing/border/TitledBorder/setTitlePosition.java 10 Oct 2005 08:06:09 -0000 1.1 +++ gnu/testlet/javax/swing/border/TitledBorder/setTitlePosition.java 15 Sep 2011 14:31:44 -0000 @@ -39,7 +39,7 @@ public void test(TestHarness harness) { TitledBorder b = new TitledBorder(new EmptyBorder(1, 1, 1, 1)); - harness.check(b.getTitlePosition(), TitledBorder.TOP); + harness.check(b.getTitlePosition(), TitledBorder.DEFAULT_POSITION); b.setTitlePosition(TitledBorder.BELOW_BOTTOM); harness.check(b.getTitlePosition(), TitledBorder.BELOW_BOTTOM); boolean pass = false; Can anybody please review this change? Cheers Pavel