public inbox for mauve-discuss@sourceware.org
 help / color / mirror / Atom feed
* RFC: fix for two Mauve tests - gnu/testlet/javax/swing/border/TitledBorder/setTitlePosition.java and gnu/testlet/javax/swing/border/TitledBorder/getTitlePosition.java
@ 2011-09-15 15:03 Pavel Tisnovsky
  0 siblings, 0 replies; only message in thread
From: Pavel Tisnovsky @ 2011-09-15 15:03 UTC (permalink / raw)
  To: mauve-discuss

Greetings,

I've made patch for two Mauve tests - gnu/testlet/javax/swing/border/TitledBorder/setTitlePosition.java and
gnu/testlet/javax/swing/border/TitledBorder/getTitlePosition.java.

This fix is based on the same issue which was fixed in the test javax/swing/Border/TitledBorder/constructors.java
(discussed here: http://www.cygwin.com/ml/mauve-discuss/2011-q3/msg00014.html)

diff -u -r1.1 getTitlePosition.java
--- gnu/testlet/javax/swing/border/TitledBorder/getTitlePosition.java   10 Oct 2005 08:06:08 -0000      1.1
+++ gnu/testlet/javax/swing/border/TitledBorder/getTitlePosition.java   15 Sep 2011 14:31:44 -0000
@@ -39,7 +39,7 @@
   public void test(TestHarness harness)
   {
     TitledBorder b = new TitledBorder(new EmptyBorder(1, 1, 1, 1));
-    harness.check(b.getTitlePosition(), TitledBorder.TOP);
+    harness.check(b.getTitlePosition(), TitledBorder.DEFAULT_POSITION);
     b.setTitlePosition(TitledBorder.BELOW_TOP);
     harness.check(b.getTitlePosition(), TitledBorder.BELOW_TOP);
   }
diff -u -r1.1 setTitlePosition.java
--- gnu/testlet/javax/swing/border/TitledBorder/setTitlePosition.java   10 Oct 2005 08:06:09 -0000      1.1
+++ gnu/testlet/javax/swing/border/TitledBorder/setTitlePosition.java   15 Sep 2011 14:31:44 -0000
@@ -39,7 +39,7 @@
   public void test(TestHarness harness)
   {
     TitledBorder b = new TitledBorder(new EmptyBorder(1, 1, 1, 1));
-    harness.check(b.getTitlePosition(), TitledBorder.TOP);
+    harness.check(b.getTitlePosition(), TitledBorder.DEFAULT_POSITION);
     b.setTitlePosition(TitledBorder.BELOW_BOTTOM);
     harness.check(b.getTitlePosition(), TitledBorder.BELOW_BOTTOM);
     boolean pass = false;


Can anybody please review this change?

Cheers
Pavel

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2011-09-15 15:03 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-15 15:03 RFC: fix for two Mauve tests - gnu/testlet/javax/swing/border/TitledBorder/setTitlePosition.java and gnu/testlet/javax/swing/border/TitledBorder/getTitlePosition.java Pavel Tisnovsky

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).