From: Pavel Tisnovsky <ptisnovs@redhat.com>
To: Mark Wielaard <mark@klomp.org>
Cc: mauve-discuss@sourceware.org, Omair Majid <omajid@redhat.com>
Subject: Re: RFC: Fix for Mauve test gnu/testlet/java/awt/Canvas/PaintTest.java
Date: Thu, 29 Sep 2011 09:40:00 -0000 [thread overview]
Message-ID: <4E843D79.1040002@redhat.com> (raw)
In-Reply-To: <1317113187.3361.5.camel@springer.wildebeest.org>
Mark Wielaard wrote:
> Hi Pavel,
>
> On Mon, 2011-09-26 at 17:32 +0200, Pavel Tisnovsky wrote:
>> I've made a simple patch for the Mauve test gnu/testlet/java/awt/Canvas/PaintTest.java
>>
>> This patch adds a small delay before computation of canvas size and its
>> absolute position on the screen is done. There's also added a test for
>> a color of a pixel located inside the canvas.
>
> Yes, looks fine to me. You probably always need a Robot.waitForIdle()
> after a pack()/show().
>
> Thanks,
>
> Mark
Hi Mark,
thank you for your review. I've found, that similar issue
should be fixed in some other tests. Fixes for such tests were pushed today:
2011-09-29 Pavel Tisnovsky <ptisnovs@redhat.com>
* gnu/testlet/java/awt/Button/PaintTest.java:
* gnu/testlet/java/awt/Canvas/PaintTest.java:
* gnu/testlet/java/awt/Checkbox/PaintTest.java:
* gnu/testlet/java/awt/Choice/PaintTest.java:
* gnu/testlet/java/awt/Label/PaintTest.java:
* gnu/testlet/java/awt/TextField/PaintTest.java:
Fixed these tests: added calling of robot.waitForIdle() method before
all checks, added more accurate checking of pixel colors in some cases,
comments for a new code.
Pavel
prev parent reply other threads:[~2011-09-29 9:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-26 15:30 Pavel Tisnovsky
2011-09-27 8:46 ` Mark Wielaard
2011-09-29 9:40 ` Pavel Tisnovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E843D79.1040002@redhat.com \
--to=ptisnovs@redhat.com \
--cc=mark@klomp.org \
--cc=mauve-discuss@sourceware.org \
--cc=omajid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).