From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30764 invoked by alias); 29 Sep 2011 09:40:30 -0000 Received: (qmail 30734 invoked by uid 22791); 29 Sep 2011 09:40:29 -0000 X-SWARE-Spam-Status: No, hits=-7.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 29 Sep 2011 09:40:16 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p8T9eE03014565 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 29 Sep 2011 05:40:14 -0400 Received: from dhcp-lab-190.englab.brq.redhat.com (dhcp-2-245.brq.redhat.com [10.34.2.245]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p8T9eCQI006396; Thu, 29 Sep 2011 05:40:13 -0400 Message-ID: <4E843D79.1040002@redhat.com> Date: Thu, 29 Sep 2011 09:40:00 -0000 From: Pavel Tisnovsky User-Agent: Thunderbird 2.0.0.23 (X11/20090825) MIME-Version: 1.0 To: Mark Wielaard CC: mauve-discuss@sourceware.org, Omair Majid Subject: Re: RFC: Fix for Mauve test gnu/testlet/java/awt/Canvas/PaintTest.java References: <4E809AF8.8060008@redhat.com> <1317113187.3361.5.camel@springer.wildebeest.org> In-Reply-To: <1317113187.3361.5.camel@springer.wildebeest.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact mauve-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: mauve-discuss-owner@sourceware.org X-SW-Source: 2011-q3/txt/msg00029.txt.bz2 Mark Wielaard wrote: > Hi Pavel, > > On Mon, 2011-09-26 at 17:32 +0200, Pavel Tisnovsky wrote: >> I've made a simple patch for the Mauve test gnu/testlet/java/awt/Canvas/PaintTest.java >> >> This patch adds a small delay before computation of canvas size and its >> absolute position on the screen is done. There's also added a test for >> a color of a pixel located inside the canvas. > > Yes, looks fine to me. You probably always need a Robot.waitForIdle() > after a pack()/show(). > > Thanks, > > Mark Hi Mark, thank you for your review. I've found, that similar issue should be fixed in some other tests. Fixes for such tests were pushed today: 2011-09-29 Pavel Tisnovsky * gnu/testlet/java/awt/Button/PaintTest.java: * gnu/testlet/java/awt/Canvas/PaintTest.java: * gnu/testlet/java/awt/Checkbox/PaintTest.java: * gnu/testlet/java/awt/Choice/PaintTest.java: * gnu/testlet/java/awt/Label/PaintTest.java: * gnu/testlet/java/awt/TextField/PaintTest.java: Fixed these tests: added calling of robot.waitForIdle() method before all checks, added more accurate checking of pixel colors in some cases, comments for a new code. Pavel