From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9223 invoked by alias); 16 Jan 2012 09:20:24 -0000 Received: (qmail 9201 invoked by uid 22791); 16 Jan 2012 09:20:23 -0000 X-SWARE-Spam-Status: No, hits=-7.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 16 Jan 2012 09:20:04 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q0G9K10L025892 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 16 Jan 2012 04:20:01 -0500 Received: from dhcp-lab-190.englab.brq.redhat.com (dhcp-2-199.brq.redhat.com [10.34.2.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q0G9K07Z025617; Mon, 16 Jan 2012 04:20:01 -0500 Message-ID: <4F13EC5A.5070203@redhat.com> Date: Mon, 16 Jan 2012 09:20:00 -0000 From: Pavel Tisnovsky User-Agent: Thunderbird 2.0.0.23 (X11/20090825) MIME-Version: 1.0 To: Andii Hughes CC: mauve-discuss@sourceware.org Subject: Re: RFC: Adding support for a new tag to a Mauve test tool References: <0093208b-00bd-470c-9949-7f83c02304d1@zmail14.collab.prod.int.phx2.redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact mauve-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: mauve-discuss-owner@sourceware.org X-SW-Source: 2012-q1/txt/msg00001.txt.bz2 Andii Hughes wrote: > On Jan 13, 2012 11:55 AM, "Pavel Tisnovsky" > wrote: >> >> Hi all, >> >> I'd like to add support for a new tag to a Mauve test tool. This tag > is named "CompileOptions:" >> and could be used to add specific command line options passed to a > compiler (it's different >> behavior from changing compiler options globally). >> >> Usage (in the test - btw: its compatible with ECJ and OpenJDK too): >> >> // Tags: CompileOptions: -source 1.4 >> >> or just: >> >> // CompileOptions: -source 1.4 >> >> because the "Tags:" prefix is not checked (it's true for other tags > too - I'm not sure if its >> a bug or a feature of Mauve test tool :-). >> >> Unified diff for Harness.java is stored in an attachment. >> >> Could anybody look at this change please? >> > > I've no objection to the change as it stands, but I seem to remember > there already being support for handling different Java versions (at > least, I remember writing versions in comments). Have you checked there > isn't already a way of doing this? Hi Andrew, partially yes, it's possible to specify target JDK version in a tag. For example: // Tags: JDK1.4 (and I'm glad this tag exists due to changes in standard API) But this tag is not used by the Harness tool itself. It's supported only by Ant-related tool which can select (filter/grep) only the tests with specified JDK versions and compile/run them. But even if the test is select by this Ant-tool, there's no way (AFAIK) how to specify command line flags passed to the compiler. But in some (minor) cases it's useful to be able to specify -source, -target, -bootclasspath or something similar. Btw: The mentioned Ant-tool (or are such thing called "plugin"?) is stored in mauve/gnu/anttask > >> Thank you in advance, >> Pavel >