public inbox for mauve-discuss@sourceware.org
 help / color / mirror / Atom feed
* Fwd: Patches for running mauve against wine + win32 vm
       [not found] <4f2ee4520708031409o723d606bx78689a245f9fb5ef@mail.gmail.com>
@ 2007-08-27 20:01 ` Steve McKay☄
  2007-08-28  0:40   ` Daniel Kegel
  0 siblings, 1 reply; 10+ messages in thread
From: Steve McKay☄ @ 2007-08-27 20:01 UTC (permalink / raw)
  To: mauve-discuss; +Cc: Dan Kegel

[-- Attachment #1: Type: text/plain, Size: 758 bytes --]

Hi All,

I mailed this patch to mauve-patches more than three weeks back. I
haven't received any response. Is that list dead?

How should I go about getting patches applied?

---------- Forwarded message ----------
From: Steve McKay☄ <smckay@google.com>
Date: Aug 3, 2007 2:09 PM
Subject: Patches for running mauve against wine + win32 vm
To: mauve-patches@sourceware.org
Cc: Dan Kegel <dkegel@google.com>


Hi All,

I've been working on running the mauve test suite against a wine
hosted jvm. This is primarily to check the behavior of wine + an
embedded win32 jvm. I have a couple small patches resulting from my
work (attached). How do I go about getting them reviewed/applied?

--
Steve McKay <smckay@google.com>



-- 
Steve McKay <smckay@google.com>

[-- Attachment #2: wine-testing.patch --]
[-- Type: text/x-patch, Size: 11808 bytes --]

Index: Harness.java
===================================================================
RCS file: /cvs/mauve/mauve/Harness.java,v
retrieving revision 1.29
diff -u -r1.29 Harness.java
--- Harness.java	7 Apr 2007 20:14:27 -0000	1.29
+++ Harness.java	3 Aug 2007 20:48:51 -0000
@@ -258,11 +258,14 @@
           {
             // User wants to use an input file to specify which tests to run.
             if (++i >= args.length)
-              throw new RuntimeException("No file path after '-file'.  Exit");
+              throw new RuntimeException("No argument after '-compile'.  Exit");
             if (args[i].equals("yes") || args[i].equals("true"))
               compileTests = true;
             else if (args[i].equals("no") || args[i].equals("false"))
               compileTests = false;
+            else
+              throw new RuntimeException("Missing compiles argument."
+                  + " Must be one of ['yes', 'no', 'true', 'false'].  Exit");
           }
         else if (args[i].equals("-help") || args[i].equals("--help")
                  || args[i].equals("-h"))
@@ -785,7 +788,9 @@
     runner_watcher.reset();
     
     // Tell the RunnerProcess to run test with name testName
-    runner_out.println(testName);
+    // smckay: convert the path into a class name before passing
+    // to the RunnerProcess. This allows us to test vms running under wine
+    runner_out.println(testName.replace(File.separatorChar, '.'));
     
     while (true)
       {
@@ -1060,89 +1065,92 @@
             count ++;
             sb.append(' ' + fullPath);
             
-            // Read the file, looking for the Uses: tag, and adding
-            // any files listed to a list of files to be compiled.
-            // This section of code reads the file, looking for the "Uses" tag
-            // and compiles any files it finds listed there.
-            String base = dirPath;
-            try
-            {
-              BufferedReader r = new BufferedReader(new FileReader(fullPath));
-              String temp = null;
-              temp = r.readLine();
-              while (temp != null)
-                {
-                  if (temp.contains("//"))
-                    {
-                      if (temp.contains("Uses:"))
-                        {
-                          StringTokenizer st = 
-                            new StringTokenizer
-                            (temp.substring(temp.indexOf("Uses:") + 5));
-                          while (st.hasMoreTokens())
-                            {
-                              String depend = base;
-                              String t = st.nextToken();
-                              while (t.startsWith(".." + File.separator))
-                                {
-                                  t = t.substring(3);
+            if (compileTests) {
+
+              // Read the file, looking for the Uses: tag, and adding
+              // any files listed to a list of files to be compiled.
+              // This section of code reads the file, looking for the "Uses" tag
+              // and compiles any files it finds listed there.
+              String base = dirPath;
+              try
+              {
+                BufferedReader r = new BufferedReader(new FileReader(fullPath));
+                String temp = null;
+                temp = r.readLine();
+                while (temp != null)
+                  {
+                    if (temp.contains("//"))
+                      {
+                        if (temp.contains("Uses:"))
+                          {
+                            StringTokenizer st = 
+                              new StringTokenizer
+                              (temp.substring(temp.indexOf("Uses:") + 5));
+                            while (st.hasMoreTokens())
+                              {
+                                String depend = base;
+                                String t = st.nextToken();
+                                while (t.startsWith(".." + File.separator))
+                                  {
+                                    t = t.substring(3);
+                                    depend = 
+                                      depend.substring
+                                      (0,
+                                       depend.lastIndexOf(File.separatorChar));
+                                  }
+                                depend += File.separator + t;
+                                if (depend.endsWith(".class"))
                                   depend = 
-                                    depend.substring
-                                    (0,
-                                     depend.lastIndexOf(File.separatorChar));
-                                }
-                              depend += File.separator + t;
-                              if (depend.endsWith(".class"))
-                                depend = 
-                                  depend.substring(0, depend.length() - 6);
-                              if (! depend.endsWith(".java"))
-                                depend += ".java";
-                              
-                              if (compileTest(depend) != 0)
-                                {
-                                  // One of the dependencies failed to compile, 
-                                  // so we report the test as failing and don't
-                                  // try to run it.                                  
-                                  String shortName = fullPath.substring(12, fullPath.length() - 5).
-                                  replace(File.separatorChar, '.'); 
-                                  
-                                  if (verbose)
-                                    {
-                                      System.out.println("TEST: " + shortName);
-                                      System.out.println("  FAIL: One of the " +
-                                      "dependencies failed to compile.");
-                                    }
-                                  else
-                                    {
-                                      System.out.println("FAIL: " + shortName);
-                                      System.out.println("  One of the " +
-                                      "dependencies failed to compile.");
-                                    }
-                                  total_test_fails++;
-                                  total_tests++;
-                                  sb.setLength(sb.length() - fullPath.length() - 1);
-                                  count --;
-                                }
-                            }
-                          break;
-                        }
-                      else if (temp.contains("not-a-test"))
-                        {
-                          sb.setLength(sb.length() - fullPath.length() - 1);
-                          count --;
-                        }
-                    }
-                  else if (temp.contains("implements Testlet"))
-                    // Don't read through the entire test once we've hit real code.
-                    // Note that this doesn't work for all files, only ones that 
-                    // implement Testlet, but that is most files.
-                    break;
-                  temp = r.readLine();
-                }
-            }
-            catch (IOException ioe)
-            {
-              // This shouldn't happen.
+                                    depend.substring(0, depend.length() - 6);
+                                if (! depend.endsWith(".java"))
+                                  depend += ".java";
+                                
+                                if (compileTest(depend) != 0)
+                                  {
+                                    // One of the dependencies failed to compile, 
+                                    // so we report the test as failing and don't
+                                    // try to run it.                                  
+                                    String shortName = fullPath.substring(12, fullPath.length() - 5).
+                                    replace(File.separatorChar, '.'); 
+                                    
+                                    if (verbose)
+                                      {
+                                        System.out.println("TEST: " + shortName);
+                                        System.out.println("  FAIL: One of the " +
+                                        "dependencies failed to compile.");
+                                      }
+                                    else
+                                      {
+                                        System.out.println("FAIL: " + shortName);
+                                        System.out.println("  One of the " +
+                                        "dependencies failed to compile.");
+                                      }
+                                    total_test_fails++;
+                                    total_tests++;
+                                    sb.setLength(sb.length() - fullPath.length() - 1);
+                                    count --;
+                                  }
+                              }
+                            break;
+                          }
+                        else if (temp.contains("not-a-test"))
+                          {
+                            sb.setLength(sb.length() - fullPath.length() - 1);
+                            count --;
+                          }
+                      }
+                    else if (temp.contains("implements Testlet"))
+                      // Don't read through the entire test once we've hit real code.
+                      // Note that this doesn't work for all files, only ones that 
+                      // implement Testlet, but that is most files.
+                      break;
+                    temp = r.readLine();
+                  }
+              }
+              catch (IOException ioe)
+              {
+                // This shouldn't happen.
+              }
             }
           }
         else
Index: RunnerProcess.java
===================================================================
RCS file: /cvs/mauve/mauve/RunnerProcess.java,v
retrieving revision 1.16
diff -u -r1.16 RunnerProcess.java
--- RunnerProcess.java	26 Nov 2006 23:12:41 -0000	1.16
+++ RunnerProcess.java	3 Aug 2007 20:48:52 -0000
@@ -412,7 +412,7 @@
   static void runAndReport(RunnerProcess harness, String testName)
   {
     // If this call to runtest hangs, Harness will terminate this process.
-    harness.runtest(testName.replace(File.separatorChar, '.'));
+    harness.runtest(testName);
 
     // If the test wasn't a real test, return and tell Harness so.
     if (harness.description.equals(NOT_A_TEST_DESCRIPTION))
Index: ChangeLog
===================================================================
RCS file: /cvs/mauve/mauve/ChangeLog,v
retrieving revision 1.2081
diff -u -r1.2081 ChangeLog
--- ChangeLog	24 Jul 2007 19:38:31 -0000	1.2081
+++ ChangeLog	3 Aug 2007 20:48:51 -0000
@@ -1,3 +1,14 @@
+2007-08-03  Steve McKay <smckay@google.com>
+
+	* Harness.java (runTest):
+	Transform path to class name prior to passing to RunnerProcess.
+    * Harness.java (processFolder):
+	Don't try to compile "Uses:" resources when auto compilation is
+	disabled.
+    * Harness.java (setupHarness):
+	Update flags processing for "-compile" flag to require an argument.
+	Correct erroneous error message.
+
 2007-07-24	Joshua Sumali	<jsumali@redhat.com>
 
 	* gnu/testlet/java/util/logging/XMLFormatter/formatMessage.java:

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Patches for running mauve against wine + win32 vm
  2007-08-27 20:01 ` Fwd: Patches for running mauve against wine + win32 vm Steve McKay☄
@ 2007-08-28  0:40   ` Daniel Kegel
       [not found]     ` <46D42F38.8030100@redhat.com>
  0 siblings, 1 reply; 10+ messages in thread
From: Daniel Kegel @ 2007-08-28  0:40 UTC (permalink / raw)
  To: Steve McKay☄; +Cc: mauve-discuss

It turns out this might not be such a good idea after all
for those tests which time out,
since Wine JVMs object if you kill them with a unix kill command.
Steve tried running everything in Wine, and the timeout kill
works more smoothly.


On 8/27/07, Steve McKay☄ <smckay@google.com> wrote:
> Hi All,
>
> I mailed this patch to mauve-patches more than three weeks back. I
> haven't received any response. Is that list dead?
>
> How should I go about getting patches applied?
>
> ---------- Forwarded message ----------
> From: Steve McKay☄ <smckay@google.com>
> Date: Aug 3, 2007 2:09 PM
> Subject: Patches for running mauve against wine + win32 vm
> To: mauve-patches@sourceware.org
> Cc: Dan Kegel <dkegel@google.com>
>
>
> Hi All,
>
> I've been working on running the mauve test suite against a wine
> hosted jvm. This is primarily to check the behavior of wine + an
> embedded win32 jvm. I have a couple small patches resulting from my
> work (attached). How do I go about getting them reviewed/applied?
>
> --
> Steve McKay <smckay@google.com>
>
>
>
> --
> Steve McKay <smckay@google.com>
>
>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Patches for running mauve against wine + win32 vm
       [not found]     ` <46D42F38.8030100@redhat.com>
@ 2007-08-28 15:10       ` Daniel Kegel
  2007-08-28 18:04       ` Steve McKay☄
  1 sibling, 0 replies; 10+ messages in thread
From: Daniel Kegel @ 2007-08-28 15:10 UTC (permalink / raw)
  To: Anthony Green; +Cc: Steve McKay☄, mauve-discuss

On 8/28/07, Anthony Green <green@redhat.com> wrote:
> Daniel Kegel wrote:
> > It turns out this might not be such a good idea after all
> > for those tests which time out,
>
> Are you saying that you not want these patches applied?  I don't see
> anything in here related to timeouts.

The patches are ok.  It's just that the whole concept of running
the harness in Linux and the tests in Wine is a little iffy,
since when a test times out, the Linux kill command makes
the Wine JVM unhappy.  Wine JVMs prefer to be killed by Windows kill commands.
- Dan

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Patches for running mauve against wine + win32 vm
       [not found]     ` <46D42F38.8030100@redhat.com>
  2007-08-28 15:10       ` Daniel Kegel
@ 2007-08-28 18:04       ` Steve McKay☄
  2007-08-31 17:33         ` Steve McKay☄
  1 sibling, 1 reply; 10+ messages in thread
From: Steve McKay☄ @ 2007-08-28 18:04 UTC (permalink / raw)
  To: Anthony Green; +Cc: Daniel Kegel, mauve-discuss

Hi Anthony,

I experienced a problem unrelated to these changes, in which some
tests were not timing out correctly causing the entire suite to hang.
As you noted, that problem isn't addressed in the patch. Dan made
mention of that due to the fact that one of the changes in the patch
("Transform path to class name prior to passing to RunnerProcess") was
needed in order to get thing working with the mixed Linux/Wine
environment. The change is still reasonable and I'd still like to see
the full patch applied.

Changes (from the changelog patch):

+	* Harness.java (runTest):
+	Transform path to class name prior to passing to RunnerProcess.
+    * Harness.java (processFolder):
+	Don't try to compile "Uses:" resources when auto compilation is
+	disabled.
+    * Harness.java (setupHarness):
+	Update flags processing for "-compile" flag to require an argument.
+	Correct erroneous error message.

On 8/28/07, Anthony Green <green@redhat.com> wrote:
> Daniel Kegel wrote:
> > It turns out this might not be such a good idea after all
> > for those tests which time out,
>
> Are you saying that you not want these patches applied?  I don't see
> anything in here related to timeouts.
>
> Thanks,
>
> AG
>
> > since Wine JVMs object if you kill them with a unix kill command.
> > Steve tried running everything in Wine, and the timeout kill
> > works more smoothly.
> >
> >
> > On 8/27/07, Steve McKay☄ <smckay@google.com> wrote:
> >> Hi All,
> >>
> >> I mailed this patch to mauve-patches more than three weeks back. I
> >> haven't received any response. Is that list dead?
> >>
> >> How should I go about getting patches applied?
> >>
> >> ---------- Forwarded message ----------
> >> From: Steve McKay☄ <smckay@google.com>
> >> Date: Aug 3, 2007 2:09 PM
> >> Subject: Patches for running mauve against wine + win32 vm
> >> To: mauve-patches@sourceware.org
> >> Cc: Dan Kegel <dkegel@google.com>
> >>
> >>
> >> Hi All,
> >>
> >> I've been working on running the mauve test suite against a wine
> >> hosted jvm. This is primarily to check the behavior of wine + an
> >> embedded win32 jvm. I have a couple small patches resulting from my
> >> work (attached). How do I go about getting them reviewed/applied?
> >>
> >> --
> >> Steve McKay <smckay@google.com>
> >>
> >>
> >>
> >> --
> >> Steve McKay <smckay@google.com>
> >>
> >>
>
>
>


-- 
Steve McKay <smckay@google.com>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Patches for running mauve against wine + win32 vm
  2007-08-28 18:04       ` Steve McKay☄
@ 2007-08-31 17:33         ` Steve McKay☄
  2007-09-06 21:07           ` Steve McKay☄
  0 siblings, 1 reply; 10+ messages in thread
From: Steve McKay☄ @ 2007-08-31 17:33 UTC (permalink / raw)
  To: Anthony Green; +Cc: Daniel Kegel, mauve-discuss

Hi Anthony,

I've got more fixes in the pipeline, but I'd like to get my previous
patch cleared out if possible. Do you have any questions/need any
changes, or can the patch be applied?

--steve

On 8/28/07, Steve McKay☄ <smckay@google.com> wrote:
> Hi Anthony,
>
> I experienced a problem unrelated to these changes, in which some
> tests were not timing out correctly causing the entire suite to hang.
> As you noted, that problem isn't addressed in the patch. Dan made
> mention of that due to the fact that one of the changes in the patch
> ("Transform path to class name prior to passing to RunnerProcess") was
> needed in order to get thing working with the mixed Linux/Wine
> environment. The change is still reasonable and I'd still like to see
> the full patch applied.
>
> Changes (from the changelog patch):
>
> +       * Harness.java (runTest):
> +       Transform path to class name prior to passing to RunnerProcess.
> +    * Harness.java (processFolder):
> +       Don't try to compile "Uses:" resources when auto compilation is
> +       disabled.
> +    * Harness.java (setupHarness):
> +       Update flags processing for "-compile" flag to require an argument.
> +       Correct erroneous error message.
>
> On 8/28/07, Anthony Green <green@redhat.com> wrote:
> > Daniel Kegel wrote:
> > > It turns out this might not be such a good idea after all
> > > for those tests which time out,
> >
> > Are you saying that you not want these patches applied?  I don't see
> > anything in here related to timeouts.
> >
> > Thanks,
> >
> > AG
> >
> > > since Wine JVMs object if you kill them with a unix kill command.
> > > Steve tried running everything in Wine, and the timeout kill
> > > works more smoothly.
> > >
> > >
> > > On 8/27/07, Steve McKay☄ <smckay@google.com> wrote:
> > >> Hi All,
> > >>
> > >> I mailed this patch to mauve-patches more than three weeks back. I
> > >> haven't received any response. Is that list dead?
> > >>
> > >> How should I go about getting patches applied?
> > >>
> > >> ---------- Forwarded message ----------
> > >> From: Steve McKay☄ <smckay@google.com>
> > >> Date: Aug 3, 2007 2:09 PM
> > >> Subject: Patches for running mauve against wine + win32 vm
> > >> To: mauve-patches@sourceware.org
> > >> Cc: Dan Kegel <dkegel@google.com>
> > >>
> > >>
> > >> Hi All,
> > >>
> > >> I've been working on running the mauve test suite against a wine
> > >> hosted jvm. This is primarily to check the behavior of wine + an
> > >> embedded win32 jvm. I have a couple small patches resulting from my
> > >> work (attached). How do I go about getting them reviewed/applied?
> > >>
> > >> --
> > >> Steve McKay <smckay@google.com>
> > >>
> > >>
> > >>
> > >> --
> > >> Steve McKay <smckay@google.com>
> > >>
> > >>
> >
> >
> >
>
>
> --
> Steve McKay <smckay@google.com>
>


-- 
Steve McKay <smckay@google.com>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Patches for running mauve against wine + win32 vm
  2007-08-31 17:33         ` Steve McKay☄
@ 2007-09-06 21:07           ` Steve McKay☄
  2007-09-06 21:39             ` Daniel Kegel
  0 siblings, 1 reply; 10+ messages in thread
From: Steve McKay☄ @ 2007-09-06 21:07 UTC (permalink / raw)
  To: Anthony Green; +Cc: Daniel Kegel, mauve-discuss

Hi All,

This is taking quite a bit longer than I expected. Am I going about
things the right way? Is there anything I can do to expedite the
process?

--steve

On 8/31/07, Steve McKay☄ <smckay@google.com> wrote:
> Hi Anthony,
>
> I've got more fixes in the pipeline, but I'd like to get my previous
> patch cleared out if possible. Do you have any questions/need any
> changes, or can the patch be applied?
>
> --steve
>
> On 8/28/07, Steve McKay☄ <smckay@google.com> wrote:
> > Hi Anthony,
> >
> > I experienced a problem unrelated to these changes, in which some
> > tests were not timing out correctly causing the entire suite to hang.
> > As you noted, that problem isn't addressed in the patch. Dan made
> > mention of that due to the fact that one of the changes in the patch
> > ("Transform path to class name prior to passing to RunnerProcess") was
> > needed in order to get thing working with the mixed Linux/Wine
> > environment. The change is still reasonable and I'd still like to see
> > the full patch applied.
> >
> > Changes (from the changelog patch):
> >
> > +       * Harness.java (runTest):
> > +       Transform path to class name prior to passing to RunnerProcess.
> > +    * Harness.java (processFolder):
> > +       Don't try to compile "Uses:" resources when auto compilation is
> > +       disabled.
> > +    * Harness.java (setupHarness):
> > +       Update flags processing for "-compile" flag to require an argument.
> > +       Correct erroneous error message.
> >
> > On 8/28/07, Anthony Green <green@redhat.com> wrote:
> > > Daniel Kegel wrote:
> > > > It turns out this might not be such a good idea after all
> > > > for those tests which time out,
> > >
> > > Are you saying that you not want these patches applied?  I don't see
> > > anything in here related to timeouts.
> > >
> > > Thanks,
> > >
> > > AG
> > >
> > > > since Wine JVMs object if you kill them with a unix kill command.
> > > > Steve tried running everything in Wine, and the timeout kill
> > > > works more smoothly.
> > > >
> > > >
> > > > On 8/27/07, Steve McKay☄ <smckay@google.com> wrote:
> > > >> Hi All,
> > > >>
> > > >> I mailed this patch to mauve-patches more than three weeks back. I
> > > >> haven't received any response. Is that list dead?
> > > >>
> > > >> How should I go about getting patches applied?
> > > >>
> > > >> ---------- Forwarded message ----------
> > > >> From: Steve McKay☄ <smckay@google.com>
> > > >> Date: Aug 3, 2007 2:09 PM
> > > >> Subject: Patches for running mauve against wine + win32 vm
> > > >> To: mauve-patches@sourceware.org
> > > >> Cc: Dan Kegel <dkegel@google.com>
> > > >>
> > > >>
> > > >> Hi All,
> > > >>
> > > >> I've been working on running the mauve test suite against a wine
> > > >> hosted jvm. This is primarily to check the behavior of wine + an
> > > >> embedded win32 jvm. I have a couple small patches resulting from my
> > > >> work (attached). How do I go about getting them reviewed/applied?
> > > >>
> > > >> --
> > > >> Steve McKay <smckay@google.com>
> > > >>
> > > >>
> > > >>
> > > >> --
> > > >> Steve McKay <smckay@google.com>
> > > >>
> > > >>
> > >
> > >
> > >
> >
> >
> > --
> > Steve McKay <smckay@google.com>
> >
>
>
> --
> Steve McKay <smckay@google.com>
>


-- 
Steve McKay <smckay@google.com>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Patches for running mauve against wine + win32 vm
  2007-09-06 21:07           ` Steve McKay☄
@ 2007-09-06 21:39             ` Daniel Kegel
  2007-09-07  5:16               ` Casey Marshall
  0 siblings, 1 reply; 10+ messages in thread
From: Daniel Kegel @ 2007-09-06 21:39 UTC (permalink / raw)
  To: Steve McKay☄; +Cc: Anthony Green, mauve-discuss

On 9/6/07, Steve McKay☄ <smckay@google.com> wrote:
> > I've got more fixes in the pipeline, but I'd like to get my previous
> > patch cleared out if possible. Do you have any questions/need any
> > changes, or can the patch be applied?
> This is taking quite a bit longer than I expected. Am I going about
> things the right way? Is there anything I can do to expedite the
> process?

Patience, grasshopper.  I'd say the thing to do is simply
post all your patches, and make sure to explain why each
one is needed.  It might also be a good idea to have a little
web page somewhere explaining what you are doing
that also links to all your patches.
- Dan

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Patches for running mauve against wine + win32 vm
  2007-09-06 21:39             ` Daniel Kegel
@ 2007-09-07  5:16               ` Casey Marshall
  2007-09-07 22:50                 ` Steve McKay☄
  0 siblings, 1 reply; 10+ messages in thread
From: Casey Marshall @ 2007-09-07  5:16 UTC (permalink / raw)
  To: Daniel Kegel; +Cc:  Steve McKay☄ , Anthony Green, mauve-discuss

On Sep 6, 2007, at 2:38 PM, Daniel Kegel wrote:

> On 9/6/07, Steve McKay☄ <smckay@google.com> wrote:
>>> I've got more fixes in the pipeline, but I'd like to get my previous
>>> patch cleared out if possible. Do you have any questions/need any
>>> changes, or can the patch be applied?
>> This is taking quite a bit longer than I expected. Am I going about
>> things the right way? Is there anything I can do to expedite the
>> process?
>
> Patience, grasshopper.  I'd say the thing to do is simply
> post all your patches, and make sure to explain why each
> one is needed.  It might also be a good idea to have a little
> web page somewhere explaining what you are doing
> that also links to all your patches.
>

As a left-field idea, since I think most people formerly involved  
with Mauve have their attention elsewhere, it might just be fine to  
get Steve CVS write access to Mauve. The contribution policy for  
Mauve is AFAIK liberal enough (probably something like "put your  
copyright notice on stuff you contribute, and please make it GPL")  
that it might be fine for you to just check this stuff in.

I think the request form is still: http://sources.redhat.com/cgi-bin/ 
pdw/ps_form.cgi

(note, I'm not recognized as someone who can approve CVS requests for  
sourceware.org, I'm just commenting from the peanut gallery)

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Patches for running mauve against wine + win32 vm
  2007-09-07  5:16               ` Casey Marshall
@ 2007-09-07 22:50                 ` Steve McKay☄
       [not found]                   ` <46E1DCB1.8090405@redhat.com>
  0 siblings, 1 reply; 10+ messages in thread
From: Steve McKay☄ @ 2007-09-07 22:50 UTC (permalink / raw)
  To: Casey Marshall; +Cc: Daniel Kegel, Anthony Green, mauve-discuss

Thanks for the tip, Casey.

Would anyone out there be willing to provide the necessary approval?
The form requires I specify the approver up front.

--steve

On 9/6/07, Casey Marshall <csm@gnu.org> wrote:
> On Sep 6, 2007, at 2:38 PM, Daniel Kegel wrote:
>
> > On 9/6/07, Steve McKay☄ <smckay@google.com> wrote:
> >>> I've got more fixes in the pipeline, but I'd like to get my previous
> >>> patch cleared out if possible. Do you have any questions/need any
> >>> changes, or can the patch be applied?
> >> This is taking quite a bit longer than I expected. Am I going about
> >> things the right way? Is there anything I can do to expedite the
> >> process?
> >
> > Patience, grasshopper.  I'd say the thing to do is simply
> > post all your patches, and make sure to explain why each
> > one is needed.  It might also be a good idea to have a little
> > web page somewhere explaining what you are doing
> > that also links to all your patches.
> >
>
> As a left-field idea, since I think most people formerly involved
> with Mauve have their attention elsewhere, it might just be fine to
> get Steve CVS write access to Mauve. The contribution policy for
> Mauve is AFAIK liberal enough (probably something like "put your
> copyright notice on stuff you contribute, and please make it GPL")
> that it might be fine for you to just check this stuff in.
>
> I think the request form is still: http://sources.redhat.com/cgi-bin/
> pdw/ps_form.cgi
>
> (note, I'm not recognized as someone who can approve CVS requests for
> sourceware.org, I'm just commenting from the peanut gallery)


-- 
Steve McKay <smckay@google.com>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Patches for running mauve against wine + win32 vm
       [not found]                   ` <46E1DCB1.8090405@redhat.com>
@ 2007-09-12 22:32                     ` Steve McKay☄
  0 siblings, 0 replies; 10+ messages in thread
From: Steve McKay☄ @ 2007-09-12 22:32 UTC (permalink / raw)
  To: Anthony Green; +Cc: Casey Marshall, Daniel Kegel, mauve-discuss

Thanks, everyone. The request has been submitted using the form. I'll
follow up with tromey@redhat.com if I have any problems.

--steve

On 9/7/07, Anthony Green <green@redhat.com> wrote:
> Steve McKay☄ wrote:
> > Thanks for the tip, Casey.
> >
> > Would anyone out there be willing to provide the necessary approval?
> > The form requires I specify the approver up front.
>
> Sure, use me.  I was going to suggest this as well.
>
> Thanks,
>
> AG
>
>
>
>


-- 
Steve McKay <smckay@google.com>

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2007-09-12 22:32 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <4f2ee4520708031409o723d606bx78689a245f9fb5ef@mail.gmail.com>
2007-08-27 20:01 ` Fwd: Patches for running mauve against wine + win32 vm Steve McKay☄
2007-08-28  0:40   ` Daniel Kegel
     [not found]     ` <46D42F38.8030100@redhat.com>
2007-08-28 15:10       ` Daniel Kegel
2007-08-28 18:04       ` Steve McKay☄
2007-08-31 17:33         ` Steve McKay☄
2007-09-06 21:07           ` Steve McKay☄
2007-09-06 21:39             ` Daniel Kegel
2007-09-07  5:16               ` Casey Marshall
2007-09-07 22:50                 ` Steve McKay☄
     [not found]                   ` <46E1DCB1.8090405@redhat.com>
2007-09-12 22:32                     ` Steve McKay☄

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).