From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Tromey To: "Aaron M. Renn" Cc: mauve-discuss@sourceware.cygnus.com Subject: Re: StringBufferInputStream Tests Date: Wed, 16 Dec 1998 13:24:00 -0000 Message-id: <8790g7rd2g.fsf@cygnus.com> In-reply-to: "Aaron M. Renn"'s message of Tue, 15 Dec 1998 20:54:33 -0600 References: <367720E9.8FE3E0B3@urbanophile.com> X-SW-Source: 1998-12/msg00079.html >>>>> "Aaron" == Aaron M Renn writes: Aaron> I converted my StringBufferInputStream tests and popped them Aaron> into CVS. Please look at them an comment. The `test' method should not be `static'. Also, you need a no-arg constructor (if the testlet doesn't have any other constructor, the implicit one is fine). I've fixed these problems. I've been writing ChangeLog entries for the changes I make. I'd prefer if everybody did this. Aaron> Note that I am assuming that check(x,x) takes an extra String Aaron> descriptive message as described earlier. I've added methods along these lines. They are just convenience wrappers for the existing check methods. Aaron> It appears that we also try to compile all classes in one big Aaron> command line. Is this wise? I'm wondering if this has Aaron> something to do with my problem. I don't know if it is wise or not. On some systems, e.g. those with command-line length limits, it is probably wrong thing to do. Feel free to fix this somehow, if you like. I'm not particularly motivated to do it myself right now... Tom