public inbox for mauve-discuss@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@cygnus.com>
To: "Aaron M. Renn" <arenn@urbanophile.com>
Cc: Uncle George <gatgul@voicenet.com>, mauve-discuss@sourceware.cygnus.com
Subject: Re: Java 1.2
Date: Thu, 25 Mar 1999 19:42:00 -0000	[thread overview]
Message-ID: <87vhfogbje.fsf@cygnus.com> (raw)
In-Reply-To: <19990325211300.B13388@urbanophile.com>

>>>>> "Aaron" == Aaron M Renn <arenn@urbanophile.com> writes:

Aaron> You do bring up an interesting case.  I believe one assumption
Aaron> of the test selection script is that Java 1.2 includes all Java
Aaron> 1.0 and Java 1.1 tests.  For items such as these which test
Aaron> that interfaces are defined correctly at a particular spec
Aaron> level, this assumption is not valid.

I believe you can write a tags line like:

	// Tags: JDK1.1 !JDK1.2

and that will do the right thing -- include the test when 1.1 is
specified, but not when 1.2 is specified.

I don't know anything about java.sql and wouldn't be comfortable
making the change myself.

Aaron> I'm not sure what you mean by character sets, but there are
Aaron> still some unresolved errors being reported out of the
Aaron> java.lang.Character test.  It reports over 100 errors for the
Aaron> JDK implementation.  Part of this is because we use the latest
Aaron> and greatest Unicode spec, while Sun uses an outdated one.
Aaron> Others may be bugs in the test script or the Java
Aaron> implementation.

Yes, all three probably apply:

* Sun's JDK 1.0 and JDK 1.1 use an outdated Unicode spec.
  I think we should just let these remain errors.

* Sun's JDK 1.0 and 1.1 (haven't tried 1.2) have bugs in their
  Character implementation.

* I once wrote Sun and asked about the apparently self-contradictory
  documentation in the online 1.2 docs for Character.isLower.  Their
  reply is that the `Ll' rule applies and the rest is just expository.
  This means there is a bug in the current test suite (if you believe
  their reply, which I occasionally do not).
  I haven't had the time to look into this yet.

The Character tests are really the most problematic.  Sun's
documentation is lacking, and so I sometimes picked what I thought was
the most reasonable and useful behavior.  Perhaps we should just aim
for 1.2 compatibility (excluding whatever obvious bugs we might find).

>> 2) Who deceides what is correct for DecimalFormat.  ( documentation
>> or Current JDK1.2 implimentation?)

Aaron> I'm not familiar with the test for this class.  However, we
Aaron> should base our tests on the documentation unless there is some
Aaron> reason to believe it is wrong.  (A typo, for example).  Sun's
Aaron> implementation has bugs, and we should not require bug for bug
Aaron> compatibility.

Aaron> A certain level of compatibility is desireable though.

I agree.  There is a fair amount of gray in the picture, since Sun's
documentation isn't all that great (parts are better than others).

When writing new java.text tests (java.text has particularly poor
documentation), I've been trying to test things which are more or less
unambiguous.  I might have failed -- this, like everything, is up for
discussion, patches, etc.


For DecimalFormat, I ran my test cases against our implementation and
against JDK 1.1.6 (I think -- or was it 1.1.5?).  Feel free to report
specific problems!  I don't have JDK 1.2 yet.

Aaron> That would be excellent.  If you write anything, please send it
Aaron> to Anthony Green or Tom Tromey at Cygnus.  Patches to existing
Aaron> tests can be posted to the list for now.

Yeah, send them on out.  If you write more than a few, we'll see about
getting you direct cvs access.

Tom

WARNING: multiple messages have this Message-ID
From: Tom Tromey <tromey@cygnus.com>
To: "Aaron M. Renn" <arenn@urbanophile.com>
Cc: Uncle George <gatgul@voicenet.com>, mauve-discuss@sourceware.cygnus.com
Subject: Re: Java 1.2
Date: Thu, 01 Apr 1999 00:00:00 -0000	[thread overview]
Message-ID: <87vhfogbje.fsf@cygnus.com> (raw)
Message-ID: <19990401000000.T-UVSERY9UGOZjxxwa7dHe0xdTtg0oQjWqkV_im7czI@z> (raw)
In-Reply-To: <19990325211300.B13388@urbanophile.com>

>>>>> "Aaron" == Aaron M Renn <arenn@urbanophile.com> writes:

Aaron> You do bring up an interesting case.  I believe one assumption
Aaron> of the test selection script is that Java 1.2 includes all Java
Aaron> 1.0 and Java 1.1 tests.  For items such as these which test
Aaron> that interfaces are defined correctly at a particular spec
Aaron> level, this assumption is not valid.

I believe you can write a tags line like:

	// Tags: JDK1.1 !JDK1.2

and that will do the right thing -- include the test when 1.1 is
specified, but not when 1.2 is specified.

I don't know anything about java.sql and wouldn't be comfortable
making the change myself.

Aaron> I'm not sure what you mean by character sets, but there are
Aaron> still some unresolved errors being reported out of the
Aaron> java.lang.Character test.  It reports over 100 errors for the
Aaron> JDK implementation.  Part of this is because we use the latest
Aaron> and greatest Unicode spec, while Sun uses an outdated one.
Aaron> Others may be bugs in the test script or the Java
Aaron> implementation.

Yes, all three probably apply:

* Sun's JDK 1.0 and JDK 1.1 use an outdated Unicode spec.
  I think we should just let these remain errors.

* Sun's JDK 1.0 and 1.1 (haven't tried 1.2) have bugs in their
  Character implementation.

* I once wrote Sun and asked about the apparently self-contradictory
  documentation in the online 1.2 docs for Character.isLower.  Their
  reply is that the `Ll' rule applies and the rest is just expository.
  This means there is a bug in the current test suite (if you believe
  their reply, which I occasionally do not).
  I haven't had the time to look into this yet.

The Character tests are really the most problematic.  Sun's
documentation is lacking, and so I sometimes picked what I thought was
the most reasonable and useful behavior.  Perhaps we should just aim
for 1.2 compatibility (excluding whatever obvious bugs we might find).

>> 2) Who deceides what is correct for DecimalFormat.  ( documentation
>> or Current JDK1.2 implimentation?)

Aaron> I'm not familiar with the test for this class.  However, we
Aaron> should base our tests on the documentation unless there is some
Aaron> reason to believe it is wrong.  (A typo, for example).  Sun's
Aaron> implementation has bugs, and we should not require bug for bug
Aaron> compatibility.

Aaron> A certain level of compatibility is desireable though.

I agree.  There is a fair amount of gray in the picture, since Sun's
documentation isn't all that great (parts are better than others).

When writing new java.text tests (java.text has particularly poor
documentation), I've been trying to test things which are more or less
unambiguous.  I might have failed -- this, like everything, is up for
discussion, patches, etc.


For DecimalFormat, I ran my test cases against our implementation and
against JDK 1.1.6 (I think -- or was it 1.1.5?).  Feel free to report
specific problems!  I don't have JDK 1.2 yet.

Aaron> That would be excellent.  If you write anything, please send it
Aaron> to Anthony Green or Tom Tromey at Cygnus.  Patches to existing
Aaron> tests can be posted to the list for now.

Yeah, send them on out.  If you write more than a few, we'll see about
getting you direct cvs access.

Tom

  reply	other threads:[~1999-03-25 19:42 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1999-03-25 14:45 Aaron M. Renn
1999-03-25 16:29 ` Uncle George
1999-03-25 19:09   ` Aaron M. Renn
1999-03-25 19:42     ` Tom Tromey [this message]
1999-03-27  3:38       ` Java 1.2: DescriptorTest.java Uncle George
1999-04-01  0:00         ` Uncle George
1999-04-01  0:00       ` Java 1.2 Tom Tromey
1999-04-01  0:00     ` Aaron M. Renn
1999-03-25 19:43   ` Tom Tromey
1999-03-25 21:21     ` Christoph Toshok
1999-04-01  0:00       ` Christoph Toshok
1999-04-01  0:00     ` Tom Tromey
1999-04-01  0:00   ` Uncle George
1999-04-01  0:00 ` Aaron M. Renn
     [not found] <36FA44BC.43E205A5@voicenet.com>
1999-03-25 14:23 ` Uncle George
1999-04-01  0:00   ` Uncle George

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vhfogbje.fsf@cygnus.com \
    --to=tromey@cygnus.com \
    --cc=arenn@urbanophile.com \
    --cc=gatgul@voicenet.com \
    --cc=mauve-discuss@sourceware.cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).