Re: [classpath] Math.min

Re: [classpath] Math.min

[Eric Blake]

Have you tried my recent patch to Mauve that allows direct comparison of
floats and doubles, without resorting to String comparison?  You should be
able to write the tests like this:

harness.check(Math.min(Double.NaN, 2.0), Double.NaN);

--
Eric Blake, Elixent, Castlemead, Lwr Castle St., Bristol BS1 3AG, UK
eric.blake@elixent.com   tel:+44(0)117 917 5611


Original message [on classpath@gnu.org]:

These mauve tests fail on my JVM:

harness.check (Double.toString (Math.min (Double.NaN, 2.0)), "NaN");

harness.check (Double.toString (Math.min (Double.NEGATIVE_INFINITY,
  Double.POSITIVE_INFINITY)),
  "-Infinity");

harness.check (Double.toString (Math.min (Double.NEGATIVE_INFINITY, 0.0)),
"-Infinity");

 harness.check (Float.toString (Math.min (-1.0f, -2.0f)), "-2.0");

      harness.check (Float.toString (Math.min (2.0f, Float.NaN)), "NaN");
      harness.check (Float.toString (Math.min (Float.NaN, 2.0f)), "NaN");

harness.check (Float.toString (Math.min (Float.NEGATIVE_INFINITY,
 Float.POSITIVE_INFINITY)),
 "-Infinity");

harness.check (Float.toString (Math.min (Float.NEGATIVE_INFINITY, 0.0f)),
  "-Infinity");


John Leuner

Re: [classpath] Math.min

[John Leuner]

> Have you tried my recent patch to Mauve that allows direct comparison of
> floats and doubles, without resorting to String comparison?  You should be
> able to write the tests like this:
> 
> harness.check(Math.min(Double.NaN, 2.0), Double.NaN);

Hello Erik, 

I wasn't paying attention (or I wasn't subscribed to the list yet), so I don't know anything about your patch. I'm using the latest CVS, is it in there?
 
John Leuner
 
> Original message [on classpath@gnu.org]:
> 
> These mauve tests fail on my JVM:
> 
> harness.check (Double.toString (Math.min (Double.NaN, 2.0)), "NaN");
> 
> harness.check (Double.toString (Math.min (Double.NEGATIVE_INFINITY,
>   Double.POSITIVE_INFINITY)),
>   "-Infinity");
> 
> harness.check (Double.toString (Math.min (Double.NEGATIVE_INFINITY, 0.0)),
> "-Infinity");
> 
>  harness.check (Float.toString (Math.min (-1.0f, -2.0f)), "-2.0");
> 
>       harness.check (Float.toString (Math.min (2.0f, Float.NaN)), "NaN");
>       harness.check (Float.toString (Math.min (Float.NaN, 2.0f)), "NaN");
> 
> harness.check (Float.toString (Math.min (Float.NEGATIVE_INFINITY,
>  Float.POSITIVE_INFINITY)),
>  "-Infinity");
> 
> harness.check (Float.toString (Math.min (Float.NEGATIVE_INFINITY, 0.0f)),
>   "-Infinity");
> 
> 
> John Leuner
> 

-- 

RE: [classpath] Math.min

[Eric Blake]

Yes, it is in CVS.  I didn't really mention my patch on this list, assuming
that the automatic message on mauve-cvs was adequate (besides, this list had
not been very active at the time).  I guess several existing tests could be
updated to take advantage of the newer code in TestHarness, not just the
ones you mentioned.

--
Eric Blake, Elixent, Castlemead, Lwr Castle St., Bristol BS1 3AG, UK
eric.blake@elixent.com   tel:+44(0)117 917 5611


> -----Original Message-----
> From: John Leuner [ mailto:jewel@pixie.co.za ]
> Sent: 10 August 2001 21:57
> To: Eric Blake
> Cc: mauve-discuss@sources.redhat.com
> Subject: Re: [classpath] Math.min
>
>
> > Have you tried my recent patch to Mauve that allows direct comparison of
> > floats and doubles, without resorting to String comparison?
> You should be
> > able to write the tests like this:
> >
> > harness.check(Math.min(Double.NaN, 2.0), Double.NaN);
>
> Hello Erik,
>
> I wasn't paying attention (or I wasn't subscribed to the list
> yet), so I don't know anything about your patch. I'm using the
> latest CVS, is it in there?
>
> John Leuner
>