RE: New locks tests need -Dmauve.vmexec set

["Jeroen Frijters" <jeroen@sumatra.nl>]

[-- Attachment #1: Type: text/plain, Size: 566 bytes --]

Mark Wielaard wrote:
> I just checked in the following for the new file lock tests.

Thanks, this is a really awesome test!

> I have updated runner to pass -Dmauve.vmexec=$RUNTIME.

This is nice feature that might be helpful for other tests as well.
Maybe we should add a method to TestHarness to start up a new VM?

I made one small change to your code, to first stop the seconday process
and only then delete the file, because on Windows you cannot delete that
is open (unless you explicitly allow this, which the JVMs don't do).

Regards,
Jeroen

[-- Attachment #2: lock.patch.txt --]
[-- Type: text/plain, Size: 699 bytes --]

Index: gnu/testlet/java/nio/channels/FileChannel/lock.java
===================================================================
RCS file: /cvs/mauve/mauve/gnu/testlet/java/nio/channels/FileChannel/lock.java,v
retrieving revision 1.1
diff -u -r1.1 lock.java
--- gnu/testlet/java/nio/channels/FileChannel/lock.java	31 Jul 2005 17:42:53 -0000	1.1
+++ gnu/testlet/java/nio/channels/FileChannel/lock.java	1 Aug 2005 09:21:03 -0000
@@ -179,7 +179,6 @@
 		harness.debug(ioe);
 	      }
 	  }
-	harness.check(file.delete(), "cleanup " + file);
 
 	try
 	  {
@@ -199,6 +198,8 @@
 	  {
 	    harness.debug(ie);
 	  }
+
+	harness.check(file.delete(), "cleanup " + file);
       }
   }