From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31063 invoked by alias); 27 Sep 2005 08:20:46 -0000 Mailing-List: contact mauve-discuss-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: mauve-discuss-owner@sources.redhat.com Received: (qmail 31015 invoked by uid 22791); 27 Sep 2005 08:20:36 -0000 Received: from [130.228.251.10] (HELO mail.sagemdenmark.dk) (130.228.251.10) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Tue, 27 Sep 2005 08:20:36 +0000 Received: from gls03001.et-ascom.dk by mail.sagemdenmark.dk via smtpd (for sourceware.org [12.107.209.250]) with ESMTP; Tue, 27 Sep 2005 10:20:27 +0200 MIME-Version: 1.0 To: mauve-discuss@sourceware.org From: Torben.Nielsen@sagemdenmark.dk Subject: Bug in getEncoding testcase Date: Tue, 27 Sep 2005 08:20:00 -0000 Message-ID: Content-type: text/plain; charset=us-ascii X-SW-Source: 2005-q3/txt/msg00065.txt.bz2 A few weeks ago I posted this patch to mauve-patches. Since it is still unchanged in cvs, I would like to ask if I posted to the wrong list, or if there is a problem with the patch. The problem with the existing testcase is that contradictory to the test description in the top of the file, it requires the extended charsets to be present, causing numerous false error reports. Index: gnu/testlet/java/io/InputStreamReader/getEncoding.java =================================================================== RCS file: /cvs/mauve/mauve/gnu/testlet/java/io/InputStreamReader/getEncoding.java,v retrieving revision 1.1 diff -u -F^f -r1.1 getEncoding.java --- gnu/testlet/java/io/InputStreamReader/getEncoding.java 17 Jun 2005 01:49:48 -0000 1.1 +++ gnu/testlet/java/io/InputStreamReader/getEncoding.java 7 Sep 2005 14:06:06 -0000 @@ -165,8 +165,8 @@ } catch (UnsupportedCharsetException uce) { supported = false; } - harness.check(name, extIoNames[i]); - harness.check(supported, true); + if ( supported ) + harness.check(name, extIoNames[i]); } }