public inbox for mauve-discuss@sourceware.org
 help / color / mirror / Atom feed
* ResourceBundle Mauve test.
@ 2006-02-13  5:06 Pedro Izecksohn
  2006-02-13  5:30 ` Pedro Izecksohn
  0 siblings, 1 reply; 4+ messages in thread
From: Pedro Izecksohn @ 2006-02-13  5:06 UTC (permalink / raw)
  To: mauve-discuss; +Cc: classpath

gnu/testlet/java/util/ResourceBundle/getBundle.java:

at lines 177 and 187:

references to 
java.util.ResourceBundle.getBundle (String, null) is ambiguous at
Sun's JDK 1.6, as there are the following two methods:

getBundle(java.lang.String,java.util.Locale)
getBundle(java.lang.String,java.util.ResourceBundle.Control)

So it does not compile any more.

Who fix this? (I did not try to fix it yet.)

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: ResourceBundle Mauve test.
  2006-02-13  5:06 ResourceBundle Mauve test Pedro Izecksohn
@ 2006-02-13  5:30 ` Pedro Izecksohn
  2006-02-13  7:53   ` David Daney
  2006-02-13 21:58   ` Tom Tromey
  0 siblings, 2 replies; 4+ messages in thread
From: Pedro Izecksohn @ 2006-02-13  5:30 UTC (permalink / raw)
  To: mauve-discuss; +Cc: classpath

[-- Attachment #1: Type: text/plain, Size: 114 bytes --]

Proposed fix: To add a (Locale) before both null appearances. As the
.diff attached.

What do you think about it?

[-- Attachment #2: 3537689465-getBundle.java.diff --]
[-- Type: text/plain, Size: 565 bytes --]

--- getBundle.java~	2006-02-13 07:14:14.000000000 +0000
+++ getBundle.java	2006-02-13 07:14:14.000000000 +0000
@@ -174,7 +174,7 @@
 
       try 
 	{
-	  ResourceBundle.getBundle (c ("Resource1"), null);
+	  ResourceBundle.getBundle (c ("Resource1"), (Locale)null);
 	  harness.check (false);
 	}
       catch (NullPointerException ex)
@@ -184,7 +184,7 @@
 
       try 
 	{
-	  ResourceBundle.getBundle ("no such resource", null);
+	  ResourceBundle.getBundle ("no such resource", (Locale)null);
 	  harness.check (false);
 	}
       catch (NullPointerException ex)

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: ResourceBundle Mauve test.
  2006-02-13  5:30 ` Pedro Izecksohn
@ 2006-02-13  7:53   ` David Daney
  2006-02-13 21:58   ` Tom Tromey
  1 sibling, 0 replies; 4+ messages in thread
From: David Daney @ 2006-02-13  7:53 UTC (permalink / raw)
  To: Pedro Izecksohn; +Cc: mauve-discuss, classpath

Pedro Izecksohn wrote:
> Proposed fix: To add a (Locale) before both null appearances. As the
> .diff attached.
> 
> What do you think about it?
> 

I think it is correct.  That is how I was going to recommend fixing it.

> 
> ------------------------------------------------------------------------
> 
> --- getBundle.java~	2006-02-13 07:14:14.000000000 +0000
> +++ getBundle.java	2006-02-13 07:14:14.000000000 +0000
> @@ -174,7 +174,7 @@
>  
>        try 
>  	{
> -	  ResourceBundle.getBundle (c ("Resource1"), null);
> +	  ResourceBundle.getBundle (c ("Resource1"), (Locale)null);
>  	  harness.check (false);
>  	}
>        catch (NullPointerException ex)
> @@ -184,7 +184,7 @@
>  
>        try 
>  	{
> -	  ResourceBundle.getBundle ("no such resource", null);
> +	  ResourceBundle.getBundle ("no such resource", (Locale)null);
>  	  harness.check (false);
>  	}
>        catch (NullPointerException ex)

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: ResourceBundle Mauve test.
  2006-02-13  5:30 ` Pedro Izecksohn
  2006-02-13  7:53   ` David Daney
@ 2006-02-13 21:58   ` Tom Tromey
  1 sibling, 0 replies; 4+ messages in thread
From: Tom Tromey @ 2006-02-13 21:58 UTC (permalink / raw)
  To: Pedro Izecksohn; +Cc: mauve-discuss, classpath

>>>>> "Pedro" == Pedro Izecksohn <izecksohn@yahoo.com> writes:

Pedro> Proposed fix: To add a (Locale) before both null appearances. As the
Pedro> .diff attached.

Pedro> What do you think about it?

I checked it in.
Thanks.

Tom

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2006-02-13 21:58 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-02-13  5:06 ResourceBundle Mauve test Pedro Izecksohn
2006-02-13  5:30 ` Pedro Izecksohn
2006-02-13  7:53   ` David Daney
2006-02-13 21:58   ` Tom Tromey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).