From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8112 invoked by alias); 21 Dec 2005 20:30:12 -0000 Received: (qmail 8105 invoked by uid 22791); 21 Dec 2005 20:30:11 -0000 X-Spam-Check-By: sourceware.org Received: from kennke.org (HELO box7954.elkhouse.de) (213.9.79.54) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 21 Dec 2005 20:30:10 +0000 Received: from i65ef.i.strato-dslnet.de ([85.73.101.239] helo=[192.168.1.5]) by box7954.elkhouse.de with esmtpsa (TLS-1.0:RSA_ARCFOUR_MD5:16) (Exim 4.50) id 1EpBcX-0003VX-9y; Wed, 21 Dec 2005 22:35:37 +0100 Subject: Re: Patch: BasicLookAndFeel initComponentDefaults From: Roman Kennke To: Lillian Angel Cc: mauve-patches In-Reply-To: <1135196592.2929.118.camel@tow.toronto.redhat.com> References: <1135196592.2929.118.camel@tow.toronto.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-YQFr7EawgwZ9zjBdAp0i" Date: Wed, 21 Dec 2005 20:30:00 -0000 Message-Id: <1135197005.9402.102.camel@localhost.localdomain> Mime-Version: 1.0 Mailing-List: contact mauve-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: mauve-patches-owner@sourceware.org X-SW-Source: 2005/txt/msg00276.txt.bz2 --=-YQFr7EawgwZ9zjBdAp0i Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Content-length: 1252 Hi Lillian, Am Mittwoch, den 21.12.2005, 15:23 -0500 schrieb Lillian Angel: > 2005-12-20 Lillian Angel >=20 > * gnu/testlet/javax/swing/plaf/basic/BasicLookAndFeel/ > initComponentDefaults.java: > Added checks for TextArea.focusInputMap,=20 > TextField.focusInputMap, TextPane.focusInputMap, and=20 > PasswordField.focusInputMap. >=20 + harness.check(UIManager.get("PasswordField.focusInputMap") instanceof InputMapUIResource); The test could be a little more detailed. I know that lots of tests in this test class are like you did. You have implemented ~27 keybindings for each text component, it would be helpful to check all of them. Sorry, it's alot of work (ok, lots of copy+pasting ;-) ), but it's really worth the effort. So, what should be done is, check for the type and size of the Object[] value for this key, and do a check for each keystroke and binding in the array (for KeyStrokes I would do a harness.check(keystroke.toString(), "ctrl ENTER") kind of check (to avoid confusion, because both (String and KeyStroke objects) are legal for the KeyStroke part, for the binding a simple harness.check(binding, "notify-accept") kind of check will do. Would you mind adding such checks? /Roman --=-YQFr7EawgwZ9zjBdAp0i Content-Type: application/pgp-signature; name=signature.asc Content-Description: Dies ist ein digital signierter Nachrichtenteil Content-length: 189 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (GNU/Linux) iD8DBQBDqbtMn1u2YFrInbcRAuI/AKCCX7Qu+bf+5Yzhk0ObE2qSX1a13wCfabl0 XV9fTOknFNyIOH3GoLVEwwM= =pcmu -----END PGP SIGNATURE----- --=-YQFr7EawgwZ9zjBdAp0i--