[Fwd: Re: [cp-testresults] FAIL: regressions for mauve-jamvm on Fri Feb 3 19:02:27 UTC 2006]

[Fwd: Re: [cp-testresults] FAIL: regressions for mauve-jamvm on Fri Feb 3 19:02:27 UTC 2006]

[Mark Wielaard]

[-- Attachment #1.1: Type: text/plain, Size: 32 bytes --]

Sent to wrong list. Apologies.

[-- Attachment #1.2: Forwarded message - Re: [cp-testresults] FAIL: regressions for mauve-jamvm on Fri Feb 3 19:02:27 UTC 2006 --]
[-- Type: message/rfc822, Size: 3953 bytes --]

[-- Attachment #1.2.1.1.1: Type: text/plain, Size: 883 bytes --]

Hi,

On Sat, 2006-02-04 at 00:29 +0100, Mark Wielaard wrote:
> On Fri, 2006-02-03 at 19:02 +0000, cpdev@builder.classpath.org wrote:
> > Baseline from: Sun Jan 29 02:20:28 UTC 2006
> > 
> > Regressions:
> > FAIL: gnu.testlet.javax.swing.AbstractAction.putValue (number 4)
> 
> This seems the opposite to the other regression I fixed with
> SwingPropertyChangeSupport which got changed to NOT expect a
> NullPointerException.
> 
> David you seem to have written both these tests. My suggestion is to
> just drop the NullPointerException check in AbstractAction.putValue().
> What do you think?

I think that is the proper thing to do. So I did:

2006-02-12  Mark Wielaard  <mark@klomp.org>

    * gnu/testlet/javax/swing/AbstractAction/putValue.java: Don't check
    unspecified null value case.

Please yell and scream if you don't agree.

Cheers,

Mark

[-- Attachment #1.2.1.1.2: AbstractAction-putValue.patch --]
[-- Type: text/x-patch, Size: 1172 bytes --]

Index: gnu/testlet/javax/swing/AbstractAction/putValue.java
===================================================================
RCS file: /cvs/mauve/mauve/gnu/testlet/javax/swing/AbstractAction/putValue.java,v
retrieving revision 1.1
diff -u -r1.1 putValue.java
--- gnu/testlet/javax/swing/AbstractAction/putValue.java	6 Jul 2005 08:55:27 -0000	1.1
+++ gnu/testlet/javax/swing/AbstractAction/putValue.java	12 Feb 2006 13:31:44 -0000
@@ -50,20 +50,21 @@
     a1.putValue(Action.NAME, null);
     harness.check(a1.getValue(Action.NAME), null);
  
-    // try null key - it is not specified what happens here, Sun's 
-    // implementation allows it but then throws an exception if you try to
-    // retrieve the value using the null key...
+    // try null key - it is not specified what happens here
+    // so we don't explicitly test this case.
+    /*
     boolean pass = false;
     try
     {
       a1.putValue(null, "XYZ");
-      /*Object value =*/ a1.getValue(null);
+      Object value = a1.getValue(null);
     }
     catch (NullPointerException e) 
     {
       pass = true;
     }
     harness.check(pass);
+    */
   }
 
 }

[-- Attachment #1.2.1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]