From: Lillian Angel <langel@redhat.com>
To: Roman Kennke <roman@kennke.org>
Cc: mauve-patches <mauve-patches@sources.redhat.com>
Subject: Re: Patch: New Lightweight tests
Date: Wed, 22 Feb 2006 14:49:00 -0000 [thread overview]
Message-ID: <1140619749.22215.67.camel@tow.toronto.redhat.com> (raw)
In-Reply-To: <1140595904.9646.8.camel@localhost.localdomain>
On Wed, 2006-02-22 at 09:11 +0100, Roman Kennke wrote:
> Hi Lillian,
>
> I have some comments regarding the TestHarness change:
>
> +
> + /**
> + * Compares two colors.
> + *
> + * @param a -
> + * Color to compare
> + * @param b -
> + * Color to compare
> + * @param match -
> + * True if colors should be equivalent.
> + */
> + public void checkColor(Color a, Color b, boolean match)
> + {
> + if (match)
> + check(a.getRed() == b.getRed() && a.getGreen() == b.getGreen()
> + && a.getBlue() == b.getBlue());
> + else
> + check(!(a.getRed() == b.getRed() && a.getGreen() == b.getGreen()
> + && a.getBlue() == b.getBlue()));
> + }
>
> I don't understand the point here. Why not use check(color1, color2)?
> This would use equals() which also compares the rgb values (or whatever
> the color value is made up of). The match parameter is also hard to
> understand, it effectivle negates the result? check(!
> color1.equals(color2)) ?
See the reply I sent to David.
>
> /**
> + * This method checks the pixel colors of a Rectangle's corners
> + *
> + * @param r -
> + * The Robot to use to get the pixel colors.
>
> I don't know if we have rules for this in Mauve, but in Classpath we
> would have a period after corners and the @param comment written without
> the '-', without the capital T and without period. For API comments we
> basically adopted Sun's rules:
>
> http://java.sun.com/j2se/javadoc/writingdoccomments/index.html
>
> Anyway, this is only a very minor nitpick, and I don't know what the
> rules are in Mauve anyway or if we even have some, I only say it here so
> you keep it in mind in future classpath hacking :-)
>
> Roman
>
next prev parent reply other threads:[~2006-02-22 14:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-21 23:52 Lillian Angel
2006-02-21 23:55 ` Lillian Angel
2006-02-22 10:04 ` David Gilbert
2006-02-22 14:48 ` Lillian Angel
2006-02-22 17:12 ` Thomas Fitzsimmons
2006-02-22 8:12 ` Roman Kennke
2006-02-22 14:49 ` Lillian Angel [this message]
2006-02-22 10:28 ` David Gilbert
2006-02-22 14:51 ` Lillian Angel
2006-02-22 15:09 ` Michael Koch
2006-02-22 15:12 ` Lillian Angel
2006-02-22 15:55 ` FYI: " Lillian Angel
2006-02-22 17:25 ` Patch: " Thomas Fitzsimmons
2006-02-22 17:47 ` FYI: " Lillian Angel
2006-02-22 18:18 ` Lillian Angel
2006-02-24 2:02 ` Thomas Fitzsimmons
2006-02-24 14:49 ` Lillian Angel
2006-02-24 15:17 ` Lillian Angel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1140619749.22215.67.camel@tow.toronto.redhat.com \
--to=langel@redhat.com \
--cc=mauve-patches@sources.redhat.com \
--cc=roman@kennke.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).