Re: FYI: New Lightweight tests

[Lillian Angel <langel@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 432 bytes --]

Documentation is fixed.

2006-02-21  Lillian Angel  <langel@redhat.com>

        * gnu/testlet/TestHarness.java
        (checkColor): Fixed API documentation.
        (checkRectangleOuterColors): Likewise.
        * gnu/testlet/java/awt/Container/LightweightContainer.java
        (testWindow): Added documentation.
        (testLoc): Likewise.
        * gnu/testlet/java/awt/Frame/size1.java
        (test): Added documentation.



[-- Attachment #2: patch2.diff --]
[-- Type: text/x-patch, Size: 3651 bytes --]

Index: gnu/testlet/TestHarness.java
===================================================================
RCS file: /cvs/mauve/mauve/gnu/testlet/TestHarness.java,v
retrieving revision 1.21
diff -u -r1.21 TestHarness.java
--- gnu/testlet/TestHarness.java	21 Feb 2006 23:51:48 -0000	1.21
+++ gnu/testlet/TestHarness.java	22 Feb 2006 15:51:31 -0000
@@ -194,11 +194,11 @@
    * Compares two colors.
    * 
    * @param a -
-   *          Color to compare
+   *          Color to compare.
    * @param b -
-   *          Color to compare
+   *          Color to compare.
    * @param match -
-   *          True if colors should be equivalent.
+   *          true if colors should be equivalent.
    */
   public void checkColor(Color a, Color b, boolean match)
   {
@@ -215,13 +215,13 @@
    * match (or don't match) a given color.
    * 
    * @param r -
-   *          The Robot to use to get the pixel color at a location
+   *          the Robot to use to get the pixel color at a location.
    * @param rect -
-   *          The Rectangle to check
+   *          the Rectangle to check
    * @param comp -
-   *          The Color to compare the pixel colors to
+   *          the Color to compare the pixel colors to.
    * @param match -
-   *          True if the pixel outside the rectangle corner should be
+   *          true if the pixel outside the rectangle corner should be
    *          equivalent to comp.
    */
   public void checkRectangleOuterColors(Robot r, Rectangle rect, Color comp,
@@ -263,16 +263,16 @@
   }
 
   /**
-   * This method checks the pixel colors of a Rectangle's corners
+   * This method checks the pixel colors of a Rectangle's corners.
    * 
    * @param r -
-   *          The Robot to use to get the pixel colors.
+   *          the Robot to use to get the pixel colors.
    * @param rect -
-   *          The Rectangle to check.
+   *          the Rectangle to check.
    * @param comp -
-   *          The Color to compare
+   *          the Color to compare.
    * @param match -
-   *          True if the corner pixel color of the rectangle should be
+   *          true if the corner pixel color of the rectangle should be
    *          equivalent to comp.
    */
   public void checkRectangleCornerColors(Robot r, Rectangle rect, Color comp,
Index: gnu/testlet/java/awt/Container/LightweightContainer.java
===================================================================
RCS file: /cvs/mauve/mauve/gnu/testlet/java/awt/Container/LightweightContainer.java,v
retrieving revision 1.2
diff -u -r1.2 LightweightContainer.java
--- gnu/testlet/java/awt/Container/LightweightContainer.java	22 Feb 2006 00:13:48 -0000	1.2
+++ gnu/testlet/java/awt/Container/LightweightContainer.java	22 Feb 2006 15:51:31 -0000
@@ -49,6 +49,7 @@
     f.add(tc);
     f.show();
 
+    // There is a delay to avoid any race conditions.    
     r.waitForIdle();
     r.delay(300);
     
@@ -103,7 +104,8 @@
     bgHW.add(fgLW);
     fgLW.add(fgHW);
     f.show();
-    
+
+    // There is a delay to avoid any race conditions.
     r.waitForIdle();
     r.delay(300);    
     Insets i = f.getInsets();
Index: gnu/testlet/java/awt/Frame/size1.java
===================================================================
RCS file: /cvs/mauve/mauve/gnu/testlet/java/awt/Frame/size1.java,v
retrieving revision 1.2
diff -u -r1.2 size1.java
--- gnu/testlet/java/awt/Frame/size1.java	21 Feb 2006 23:51:48 -0000	1.2
+++ gnu/testlet/java/awt/Frame/size1.java	22 Feb 2006 15:51:31 -0000
@@ -83,6 +83,7 @@
     bg.show ();
     fg.show ();
 
+    // There is a delay to avoid any race conditions.
     r.waitForIdle ();
     r.delay (100);