From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17336 invoked by alias); 22 Feb 2006 17:12:26 -0000 Received: (qmail 17328 invoked by uid 22791); 22 Feb 2006 17:12:25 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 22 Feb 2006 17:12:24 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id k1MHCNmn004586 for ; Wed, 22 Feb 2006 12:12:23 -0500 Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com [172.16.14.4]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id k1MHCM104054; Wed, 22 Feb 2006 12:12:22 -0500 Received: from tortoise.toronto.redhat.com (tortoise.toronto.redhat.com [172.16.14.92]) by pobox.toronto.redhat.com (8.12.8/8.12.8) with ESMTP id k1MHCM93006998; Wed, 22 Feb 2006 12:12:22 -0500 Subject: Re: Patch: New Lightweight tests From: Thomas Fitzsimmons To: David Gilbert Cc: Lillian Angel , mauve-patches In-Reply-To: <43FC373E.9010904@object-refinery.com> References: <1140565958.22215.52.camel@tow.toronto.redhat.com> <1140566120.22215.54.camel@tow.toronto.redhat.com> <43FC373E.9010904@object-refinery.com> Content-Type: text/plain Date: Wed, 22 Feb 2006 17:12:00 -0000 Message-Id: <1140628341.1404.192.camel@tortoise.toronto.redhat.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact mauve-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: mauve-patches-owner@sourceware.org X-SW-Source: 2006/txt/msg00169.txt.bz2 On Wed, 2006-02-22 at 10:04 +0000, David Gilbert wrote: > Hi Lillian, > > I wonder if these methods should really be added to TestHarness, they > seem a little too "specialised" to me (especially the rectangle corner > color tests), and it would be nice to keep TestHarness as simple as > possible. Maybe you could create a utility class in > gnu.testlet.java.awt.* that contains static methods that perform these > checks? Then you could share that between your Frame and Container tests. Yes, it's probably cleaner to have a utility class in gnu.testlet.java.awt. Tom > > Regards, > > Dave > > Lillian Angel wrote: > > >On Tue, 2006-02-21 at 18:52 -0500, Lillian Angel wrote: > > > > > >>I added new tests for Lightweight Containers. > >> > >> > > > >I forgot to mention, I added some new methods to TestHarness. These > >methods are helpful for testing locations on the screen when using > >Lightweight/Heavyweight widgets. It made sense to add these to > >TestHarness, since they are used in Frame and Container. > > > > > > > >>2006-02-21 Lillian Angel > >> > >> * gnu/testlet/TestHarness.java > >> (checkColor): New method used to compare colors. > >> (checkRectangleOuterColors): New method used to compare the > >> colors of a rectangle's corners to the colors of the pixels > >> surrounding the corners. > >> (checkRectangleCornerColors): New method used to compare > >> the colors of the pixels at the corners of a rectangle, to > >> a given color. > >> * gnu/testlet/java/awt/Container/LightweightContainer.java: > >> New Test. > >> * gnu/testlet/java/awt/Frame/size1.java > >> (checkColor): Removed. > >> (test): Changed to use new methods in TestHarness. > >> > >> > >>