public inbox for mauve-patches@sourceware.org
 help / color / mirror / Atom feed
From: Thomas Fitzsimmons <fitzsim@redhat.com>
To: David Gilbert <david.gilbert@object-refinery.com>
Cc: Lillian Angel <langel@redhat.com>,
	        mauve-patches <mauve-patches@sources.redhat.com>
Subject: Re: Patch: New Lightweight tests
Date: Wed, 22 Feb 2006 17:25:00 -0000	[thread overview]
Message-ID: <1140629152.1404.204.camel@tortoise.toronto.redhat.com> (raw)
In-Reply-To: <43FC3D06.4060209@object-refinery.com>

On Wed, 2006-02-22 at 10:29 +0000, David Gilbert wrote:
> Hi Lillian,
> 
> Lillian Angel wrote:
> 
> >
> >Index: gnu/testlet/java/awt/Container/LightweightContainer.java
> >===================================================================
> >
> >  
> >
> 
> >+    harness.checkRectangleOuterColors(r, bounds2, Color.red, true);
> >+    harness.checkRectangleCornerColors(r, bounds2, Color.red, false);
> >+    
> >+    r.delay(3000);
> >+  }
> >  
> >
> Do you know what the delay is for?  Is there some other way to write the 
> test so that the delay isn't required?  It's just that it would be nice 
> if the Mauve test run doesn't take longer than it has to - otherwise 
> hackers will stop running it.

The three second delays are to help the human tester see the result,
though we should probably enable or disable them based on if Mauve is
running in headless mode.  The new AWT utility class that we add could
check the SHOW_GUI_TESTS environment variable and cache its value.

We require:

+    r.waitForIdle();
+    r.delay(300);

after showing a frame, before checking pixels in it so that GTK has had
time to draw it.  I think this is documented in one of the other AWT
tests.

Tom


  parent reply	other threads:[~2006-02-22 17:25 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-21 23:52 Lillian Angel
2006-02-21 23:55 ` Lillian Angel
2006-02-22 10:04   ` David Gilbert
2006-02-22 14:48     ` Lillian Angel
2006-02-22 17:12     ` Thomas Fitzsimmons
2006-02-22  8:12 ` Roman Kennke
2006-02-22 14:49   ` Lillian Angel
2006-02-22 10:28 ` David Gilbert
2006-02-22 14:51   ` Lillian Angel
2006-02-22 15:09     ` Michael Koch
2006-02-22 15:12       ` Lillian Angel
2006-02-22 15:55         ` FYI: " Lillian Angel
2006-02-22 17:25   ` Thomas Fitzsimmons [this message]
2006-02-22 17:47     ` Lillian Angel
2006-02-22 18:18       ` Lillian Angel
2006-02-24  2:02         ` Thomas Fitzsimmons
2006-02-24 14:49           ` Lillian Angel
2006-02-24 15:17             ` Lillian Angel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1140629152.1404.204.camel@tortoise.toronto.redhat.com \
    --to=fitzsim@redhat.com \
    --cc=david.gilbert@object-refinery.com \
    --cc=langel@redhat.com \
    --cc=mauve-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).